-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and add test actions #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8545e1d.
endast
added
enhancement
New feature or request
and removed
wait
Don't merge yet
labels
May 23, 2024
Marcel-Mueck
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr waits for this pr before merging to make sure all pipelines work:
#92
What
This PR makes sure we have pipeline tests for all pipelines in the repo (the annotation pipeline only has as smoke test).
It also adds reusable workflows for the pipeline and pytests workflows. This way we don't need to duplicate the code to run the tests. Also the pipelines run in parallel now so we speed up the time to run all the tests.
So now a new pipeline can be added like this (with both smoke and full tests:
Instead of this:
And new code tests (pytest) can now be added like this:
Testing
All the tests should run in github actions, so proof reading the yaml files should be enough if the pipelines pass in actions.