-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify configuration file for running deepRVAT #99
Conversation
…rvat into simplify-config-files
Simplifying association testing phenotypes .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kayla, this looks really great! I've left a few comments, please take a look.
…e pipelines -fixed configfile path in annotation pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
Allows users to interact with a deeprvat_input_config.yaml that is a more simplified configuration file with only those parameters most relevant to users. The main deeprvat_config.yaml used for the pipelines is then created automatically based on the input from deeprvat_input_config.yaml, when running a pipeline.
Testing
Testing this PR involved running the various deepRVAT pipelines using the respective
deeprvat_input_config.yaml
(see specific pipeline input configs in '/example/config/' ) . Subsequently, then testing all pipeline scripts requiring the generateddeeprvat_config.yaml
file.Instructions
Run your desired training and/or association testing snakemake pipeline, i.e.
training_association_testing.snakefile
. The snakemake pipeline expects the generateddeeprvat_config.yaml
file. Ifdeeprvat_config.yaml
has not been previously generated or supplied via the snakemake --configfile argument, then the pipelines expects a 'deeprvat_input_config.yaml' file to be present in the working directory. Then the snakemake pipeline will automatically generate the necessarydeeprvat_config.yaml
into your working directory based on 'deeprvat_input_config.yaml'.