Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/tcg/ppc64: Add mffsce test #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vcoracolombo
Copy link

Add mffsce test to check both the return value and the new fpscr
stored in the cpu.

Signed-off-by: Víctor Colombo victor.colombo@eldorado.org.br


I though I had found a bug in mffsce while I was reading the code, but it wasn't the case
so, let's contribute the test I had to write as it is already done? :)

@vcoracolombo vcoracolombo self-assigned this May 2, 2022
@vcoracolombo vcoracolombo force-pushed the vccolombo-mffsce-test branch 2 times, most recently from 44add9e to 7cf48eb Compare May 2, 2022 20:12
Add mffsce test to check both the return value and the new fpscr
stored in the cpu.

Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
Copy link

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I'm a bit worried about using binary constants, but otherwise I have only a few nitpicks.

tests/tcg/ppc64le/mffsce.c Outdated Show resolved Hide resolved
tests/tcg/ppc64le/mffsce.c Outdated Show resolved Hide resolved
tests/tcg/ppc64le/mffsce.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants