Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: workflow for ubuntu 24 #23937

Merged
merged 1 commit into from
Nov 15, 2024
Merged

ci: workflow for ubuntu 24 #23937

merged 1 commit into from
Nov 15, 2024

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Nov 13, 2024

Adds a CI workflow for GitHub Actions that builds PX4's quick_checks (px4_sitl_test, px4_fmu-v5_default, astyle) under Ubuntu 24.04. More specifically, this PR does two main things:

  • adds a matrix to the Ubuntu workflow for testing multiple Ubuntu versions
  • Runs Ubuntu versions within a container on each matrix
  • updates ubuntu.sh with fixes for Ubuntu 24.04, including Python

@mrpollo mrpollo changed the title ci: ci workflow for ubuntu 24 ci: workflow for ubuntu 24 Nov 13, 2024
@mrpollo mrpollo marked this pull request as ready for review November 13, 2024 17:12
@MaEtUgR
Copy link
Member

MaEtUgR commented Nov 13, 2024

This still fails on the python warning. Should I suggest some changes and test?
grafik

@mrpollo
Copy link
Contributor Author

mrpollo commented Nov 13, 2024

Turns out I didn't push the python fix @MaEtUgR

Tools/setup/ubuntu.sh Outdated Show resolved Hide resolved
@mrpollo mrpollo force-pushed the mrpollo/ci_ubuntu_24 branch 2 times, most recently from 703e1ea to 9728104 Compare November 13, 2024 20:41
* updates ubuntu.sh adding support for ubuntu 24.04
* ubuntu.sh now expects by default any of the last two LTS
* runs ci in docker containers
@dagar dagar merged commit 058fe54 into main Nov 15, 2024
55 of 58 checks passed
@dagar dagar deleted the mrpollo/ci_ubuntu_24 branch November 15, 2024 01:26
Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrpollo !
I just did a new setup on WSL and it by default now uses 24.04 packages. Everything works out of the box on main now thanks to your work 🙏

@MaEtUgR MaEtUgR mentioned this pull request Nov 19, 2024
6 tasks
@mrpollo
Copy link
Contributor Author

mrpollo commented Nov 19, 2024

@MaEtUgR AWESOME! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants