listener: clear screen on multiple output #23986
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest to clear the screen when using the listener with -n. This way the updates don't just scroll by which isn't legible but instead stay in place and update, similar to the top command.
FLASH Analysispx4_fmu-v5xpx4_fmu-v6x |
dagar
reviewed
Nov 20, 2024
| @@ -113,6 +113,9 @@ void listener(const orb_id_t &id, unsigned num_msgs, int topic_instance, | |||
| fds[1].fd = sub; | |||
| fds[1].events = POLLIN; | |||
|
|
|||
| // Clear screen | |||
| dprintf(1, "\033[2J\n"); | |||
There was a problem hiding this comment.
Maybe only if num_msgs > 1? Or alternatively make sure we only fall into this case if it's going to be more than 1?
or catch it here perhaps? https://github.com/PX4/PX4-Autopilot/pull/23986/files#diff-95ea6d47bf95b7f58b56e2f57e462a07eee1d497fa4c1ff7f019f8e704470db6R59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to clear the screen when using the listener with -n. This way the updates don't just scroll by which isn't legible but instead stay in place and update, similar to the top command.