-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update board_types.txt #236
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -206,6 +206,11 @@ AP_HW_CUBEBLACK_PERIPH 1401 | |||||||||
AP_HW_PIXRACER_PERIPH 1402 | ||||||||||
AP_HW_SWBOOMBOARD_PERIPH 1403 | ||||||||||
|
||||||||||
#IDs 5600-5699 reserved for ZeroOne | ||||||||||
AP_HW_ZeroOne_X6 5600 | ||||||||||
AP_HW_ZeroOne_PMU 5601 | ||||||||||
AP_HW_ZeroOne_GNSS 5602 | ||||||||||
Comment on lines
+211
to
+212
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Add to AP first then document here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, these two lines have been added to the Ardupilot. |
||||||||||
|
||||||||||
# OpenDroneID enabled boards. Use 10000 + the base board ID | ||||||||||
AP_HW_CubeOrange_ODID 10140 | ||||||||||
AP_HW_Pixhawk6_ODID 10053 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is AP_HW_ZeroOne_X6 and ZEROONE_X6 the same board? If so since you already have the AP id in Ardupilot, just add it here. Do not "Create" Ardupilot ID here that do not exist in Ardupilot yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this line already exists in the Ardupilot.