Remove thrust from altitude graph. Add HDOP, VDOP, and speed accuracy to GPS. Fix vibration instance 3 label. #284
Conversation
AlexKlimaj
force-pushed
the
pr-thrust-hdop-vdop
branch
from
30f907e
to
947cf6c
Compare
| if actuator_controls_0.thrust_z_neg is not None: | ||
| data_plot.add_graph([lambda data: ('thrust', actuator_controls_0.thrust_z_neg*100)], | ||
| colors8[6:7], ['Thrust [0, 100]']) | ||
| if 'position_setpoint_triplet' in data and 'current' in data['position_setpoint_triplet']: |
There was a problem hiding this comment.
Without this, the Y axis range always starts at 0.
There was a problem hiding this comment.
Well this isn't correct though. How did you test this?
You probably need to take into consideration the valid flag.
There was a problem hiding this comment.
Do you have a log where this doesn't work?
There was a problem hiding this comment.
Check any log that has some mission on https://logs.px4.io/browse, eg https://logs.px4.io/plot_app?log=22a7603d-edf4-476a-8b0e-0aa0a73b107b
| data_plot.add_circle(['current.alt'], [plot_config['mission_setpoint_color']], | ||
| ['Altitude Setpoint']) | ||
| data_plot.change_dataset(actuator_controls_0.thrust_sp_topic) | ||
| if actuator_controls_0.thrust_z_neg is not None: |
There was a problem hiding this comment.
Can you separate the commit and provide the reason for the change for future reference?
We could also shift the thrust into the range of the altitude instead.
There was a problem hiding this comment.
Split the commit and added a comment.
AlexKlimaj
force-pushed
the
pr-thrust-hdop-vdop
branch
from
947cf6c
to
a4dd894
Compare
Remove thrust from altitude graph. Add HDOP, VDOP, and speed accuracy to GPS. Fix vibration instance 3 label.
@dakejahl @dagar