Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing description & links to documentation #199

Open
not7cd opened this issue Jun 14, 2023 · 2 comments
Open

Confusing description & links to documentation #199

not7cd opened this issue Jun 14, 2023 · 2 comments

Comments

@not7cd
Copy link

not7cd commented Jun 14, 2023

Hey, I got confused by the role of this package.
The sidebar description says:

ROS2/ROS interface with PX4 through a Fast-RTPS bridge

While README says:

This package materializes the ROS2 side of the PX4 DDS bridge, establishing a bridge between the PX4 autopilot stack through an XRCE-DDS bridge. ...

Later it links to https://docs.px4.io/main/en/middleware/micrortps.html, which redirects to https://docs.px4.io/main/en/middleware/uxrce_dds.html. So I don't know if this package is still relevant. px4_ros_com appears 3 times on the later page without much context.

Also, README still links to the defunct Slack.

@beniaminopozzan
Copy link
Member

Hi @not7cd , yes, this repo requires some work as PX4 moved from Fast-RTPS to XRCE-DDS.
The packages itself provides a library for PX4-ROS frame conversions and some example of ROS 2 - PX4 operations.

@not7cd
Copy link
Author

not7cd commented Jun 14, 2023

I think it would be best to reflect this in the project's description then. Maybe create a highlighted text pointing out the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants