Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the humble ROS message definition target #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nigeltiany
Copy link

Add ROS humble as a target for generating -typeros2 message definitions

Add ROS humble as a target for generating ```-typeros2``` message definitions
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes on this Python script should be done on the PX4-Autopilot side instead. Then a CI/CD system would deploy the updated script here. Thanks!

@nigeltiany
Copy link
Author

nigeltiany commented Aug 24, 2022

I see. The script here includes humble. I guess the CI has not pushed the updated script here yet? This means users following the PX4 ROS tutorial and using ROS humble will be unable to complete the tutorial successfully

https://docs.px4.io/main/en/ros/ros2_comm.html#build-ros-2-workspace

To create and build the workspace:

Create a workspace directory using:
$ mkdir -p ~/px4_ros_com_ros2/src
Clone the ROS 2 bridge packages px4_ros_com and px4_msgs to the /src directory (the master branch is cloned by default):
$ git clone https://github.com/PX4/px4_ros_com.git ~/px4_ros_com_ros2/src/px4_ros_com
$ git clone https://github.com/PX4/px4_msgs.git ~/px4_ros_com_ros2/src/px4_msgs
Use the build_ros2_workspace.bash script to build the ROS 2 workspace (including px4_ros_com and px4_msgs).
$ cd ~/px4_ros_com_ros2/src/px4_ros_com/scripts
$ source build_ros2_workspace.bash

@TSC21
Copy link
Member

TSC21 commented Aug 24, 2022

I see. The script here includes humble. I guess the CI has not pushed the updated script here yet? This means a lot of users following the PX4 ROS tutorial will be unable to complete the tutorial successfully

https://docs.px4.io/main/en/ros/ros2_comm.html#build-ros-2-workspace

To create and build the workspace:

Create a workspace directory using:
$ mkdir -p ~/px4_ros_com_ros2/src
Clone the ROS 2 bridge packages px4_ros_com and px4_msgs to the /src directory (the master branch is cloned by default):
$ git clone https://github.com/PX4/px4_ros_com.git ~/px4_ros_com_ros2/src/px4_ros_com
$ git clone https://github.com/PX4/px4_msgs.git ~/px4_ros_com_ros2/src/px4_msgs
Use the build_ros2_workspace.bash script to build the ROS 2 workspace (including px4_ros_com and px4_msgs).
$ cd ~/px4_ros_com_ros2/src/px4_ros_com/scripts
$ source build_ros2_workspace.bash

That means it has to be fixed somehow. Can you report it in an issue there? Thanks!

@nigeltiany
Copy link
Author

Reported
#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants