Add hasField method to the interface #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jan 10, 2024
ulog_cpp/subscription.hpp
Outdated
| */ | ||
| bool hasField(const std::string& field_name) const | ||
| { | ||
| return _message_format_ref.field(field_name)->definitionResolved(); |
There was a problem hiding this comment.
Suggested change
| return _message_format_ref.field(field_name)->definitionResolved(); | |
| const auto iter = _message_format_ref.fieldMap().find(field_name); | |
| return iter != _message_format_ref.fieldMap().end() && iter.second->definitionResolved(); |
There was a problem hiding this comment.
There was an arrow operator missing. Should be good now.
marcinolokk
force-pushed
the
pr-add-hasField
branch
from
5a69c77
to
07daa9d
Compare
bkueng
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to check if the field exists. If so, we can safely access
rawData()and get away from copying data what seems to be done byas()method.