Add checks for invalid fields & index bounds #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC errors:
test/read_api_test.cpp: In function ‘void DOCTEST_ANON_FUNC_3()’:
test/read_api_test.cpp:104:9: error: ‘void* memcpy(void*, const void*, size_t)’ reading 17 bytes from a region of size 13 [-Werror=stringop-overread]
104 | memcpy(data_vector.data() + 12, &t02, 17);
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/read_api_test.cpp:87:14: note: source object ‘t02’ of size 13
87 | const char t02[] = "Hello World!";
| ^~~
test/read_api_test.cpp:108:9: error: ‘void* memcpy(void*, const void*, size_t)’ reading 19 bytes from a region of size 15 [-Werror=stringop-overread]
108 | memcpy(data_vector.data() + 42, &t06, 19);
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/read_api_test.cpp:91:14: note: source object ‘t06’ of size 15
91 | const char t06[] = "Hello World! 2";
| ^~~
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.
…ndex And check for it in the ulog_data example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8