Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync API spec with SDK #7

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Sync API spec with SDK #7

merged 2 commits into from
Jan 24, 2024

Conversation

vifer
Copy link
Contributor

@vifer vifer commented Jan 23, 2024

Added

  • Added importMeta to product, price, address, business, customer, discount and subscription entities
  • Added creditToBalance to transaction.details.payoutTotals and transaction.details.totals
  • Added origin query parameter to list transactions, see related changelog.
  • Added available_payment_methods to transaction with includes entity
  • Added email query parameter to list customers, see related changelog

@vifer vifer self-assigned this Jan 23, 2024
@vifer vifer requested a review from a team January 23, 2024 15:48
@vifer vifer force-pushed the feature/support-new-api-fields branch from 7e45f22 to 60c05c3 Compare January 23, 2024 15:49
mikeymike
mikeymike previously approved these changes Jan 24, 2024
Copy link
Contributor

@mikeymike mikeymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, all looks good. Just one question around a var name, will leave you to handle that and merge when ready 👍

@@ -34,6 +36,7 @@ public function __construct(
private readonly array $statuses = [],
private readonly array $subscriptionIds = [],
private readonly ?DateComparison $updatedAt = null,
private readonly array $origin = [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following on from the other variables here should we make this plural ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated ✅

@vifer vifer merged commit 21831c8 into main Jan 24, 2024
3 checks passed
@vifer vifer deleted the feature/support-new-api-fields branch January 24, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants