payment_method_id can be string or null
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API docs state that the payment_method_id can be a `string` or `null` - but the PHP code only expects a string. The value is `null` when the payment amount has been reduced to zero by a discount.
davidgrayston-paddle
approved these changes
Sep 18, 2024
|
Hello @tpetry 👋 - thank you for contributing this fix, we will include this in the next minor release that we plan to release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API docs state that the
payment_method_idcan be astringornull- but the PHP code only expects a string.The value is
nullwhen e.g. the payment amount has been reduced to zero by a discount.