Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle notification entity serialization #92

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: Handle notification entity serialization #92

merged 2 commits into from
Oct 17, 2024

Conversation

davidgrayston-paddle
Copy link
Contributor

Changed

  • Handling notification entity serialization
    • Configured DateTimeNormalizer to format date/time values
  • Reusing EntityFactory::create() in Event::from()

Fixed

  • Handle unknown event types and entities

@davidgrayston-paddle davidgrayston-paddle self-assigned this Oct 15, 2024
@davidgrayston-paddle davidgrayston-paddle marked this pull request as ready for review October 16, 2024 22:22
@davidgrayston-paddle davidgrayston-paddle requested a review from a team as a code owner October 16, 2024 22:22
@davidgrayston-paddle davidgrayston-paddle merged commit b55854f into feat/simulator-api Oct 17, 2024
3 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the feat/handle-event-serialization branch October 17, 2024 08:21
davidgrayston-paddle added a commit that referenced this pull request Oct 17, 2024
@davidgrayston-paddle
feat: Handle notification entity serialization (#92)
b5102d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifer vifer vifer approved these changes

Assignees

@davidgrayston-paddle davidgrayston-paddle

Labels
norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgrayston-paddle @vifer