Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 7th No.46】 添加对返回常量的 IfElse 算子的支持 #1383

Merged
merged 9 commits into from
Sep 20, 2024
Merged

【Hackathon 7th No.46】 添加对返回常量的 IfElse 算子的支持 #1383

merged 9 commits into from
Sep 20, 2024

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Sep 18, 2024 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Asthestarsfalll Asthestarsfalll changed the title [WIP] 添加对返回常量的 IfElse 算子的支持 【Hackathon 7th No.xxx】 添加对返回常量的 IfElse 算子的支持 Sep 18, 2024
@Asthestarsfalll Asthestarsfalll changed the title 【Hackathon 7th No.xxx】 添加对返回常量的 IfElse 算子的支持 【Hackathon 7th No.46】 添加对返回常量的 IfElse 算子的支持 Sep 18, 2024
@Zheng-Bicheng Zheng-Bicheng mentioned this pull request Sep 19, 2024
Closed
Zheng-Bicheng
Zheng-Bicheng reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@Zheng-Bicheng Zheng-Bicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大佬，再优化下代码结构。然后再帮忙做个事儿，exporter.cc/exporter.h 中可能有一些中文注释，麻烦帮忙修改为英文或者直接删除。

paddle2onnx/mapper/exporter.cc Outdated Show resolved Hide resolved
tests/test_ifelse.py Show resolved Hide resolved
@Zheng-Bicheng
Copy link
Collaborator

顺便这边有一个 PR 也是做的这个题目，是一起的嘛？

@luotao1 luotao1 mentioned this pull request Sep 19, 2024
Open
@Asthestarsfalll
Copy link
Contributor Author

顺便这边有一个 PR 也是做的这个题目，是一起的嘛？

不是哎...

@Zheng-Bicheng
Copy link
Collaborator

Zheng-Bicheng commented Sep 20, 2024 •
edited
Loading

@Asthestarsfalll 大佬，你这个 PR 好像和最新的提交有些冲突，帮忙merge下吧，merge完我给你合入哈

Zheng-Bicheng
Zheng-Bicheng approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Zheng-Bicheng Zheng-Bicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zheng-Bicheng
Zheng-Bicheng reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Zheng-Bicheng Zheng-Bicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

格式再修改下哈

paddle2onnx/mapper/exporter.cc Outdated Show resolved Hide resolved
paddle2onnx/mapper/exporter.cc Outdated Show resolved Hide resolved
@Asthestarsfalll
Copy link
Contributor Author

格式再修改下哈

已修改～

Zheng-Bicheng
Zheng-Bicheng approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Zheng-Bicheng Zheng-Bicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheng-Bicheng Zheng-Bicheng merged commit 6b4bd2f into PaddlePaddle:develop Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zheng-Bicheng Zheng-Bicheng Zheng-Bicheng approved these changes

Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asthestarsfalll @CLAassistant @Zheng-Bicheng