Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paddle Toolkit Development Competition No.4】 Paddle 适配 torch-scatter #1011

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LitLeo
Copy link

@LitLeo LitLeo commented Nov 13, 2024

赛题要求的是“尽量使用 paddle.geometric 下的基础 python API 等价组合实现上述公开 API 的功能”。跟我的实现方案是两个不同的方向,需要麻烦官方考量我的方案是否可以。可以我就继续做下去,不可以就算了。

Copy link

paddle-bot bot commented Nov 13, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交PR,推荐使用paddle.geometric下的API是因为这些希望尽量减少开发量(如果能完全等价实现的话),但是也允许基于原来的C++算子进行开发。RFC本身没有问题。

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate
Copy link
Contributor

@LitLeo 可以签署一下这个CLA协议:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants