Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multi accounts #13

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Jul 12, 2024

Description

This PR adds support for multi-account configuration to scaffolder actions. It introduces no changes for the end user and adapts to the configuration set in app-config.yaml. If multiple accounts are configured the user will see the list of all Escalation Policies in all accounts with the reference to it's source account.

multi-account escalation policy list

At creation time, the scaffolder will select the correct account to deploy the service to depending on the select escalation policy/account pair selected.

Issue number: N/A

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
@t1agob t1agob added the enhancement New feature or request label Jul 12, 2024
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
@t1agob t1agob marked this pull request as ready for review July 12, 2024 13:17
@t1agob t1agob merged commit ba230af into next Jul 12, 2024
2 checks passed
@t1agob t1agob deleted the feat/add-support-for-multi-accounts branch July 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant