Revised PR: Restrict user data access in User query (replaces #2623) #4450
pull-request.yml
on: pull_request
Check for linting, formatting, and type errors
1m 31s
Checks if sensitive files have been changed without authorization
3s
Checks if number of files changed is acceptable
4s
Base branch check
0s
Matrix: Testing Application
JSDocs comments and pipeline
0s
Annotations
4 errors and 6 warnings
tests/resolvers/Query/getVolunteerRanks.spec.ts > resolvers -> Query -> getVolunteerRanks > getVolunteerRanks for weekly, descending, limit, no name:
tests/resolvers/Query/getVolunteerRanks.spec.ts#L61
AssertionError: expected +0 to deeply equal 2
- Expected
+ Received
- 2
+ 0
❯ tests/resolvers/Query/getVolunteerRanks.spec.ts:61:48
|
tests/resolvers/Query/userAccess.spec.ts > user Query > throws error if user doesn't exist:
tests/resolvers/Query/userAccess.spec.ts#L92
AssertionError: expected 'Access denied. Only the user themselv…' to deeply equal 'User not found'
Expected: "User not found"
Received: "Access denied. Only the user themselves, organization admins, or super admins can view this profile."
❯ tests/resolvers/Query/userAccess.spec.ts:92:40
|
tests/resolvers/Query/userAccess.spec.ts > user Query > allows an admin to access another user's data within the same organization:
tests/resolvers/Query/userAccess.spec.ts#L129
AssertionError: expected [ …(1) ] to include '673116efddd5b8c880dc0257'
❯ tests/resolvers/Query/userAccess.spec.ts:129:26
|
Testing Application (22.x)
Process completed with exit code 1.
|
Checks if sensitive files have been changed without authorization
Unexpected input(s) 'persist-crendetials', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
|
Checks if sensitive files have been changed without authorization
Unexpected input(s) 'persist-crendetials', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
|
Checks if number of files changed is acceptable
Unexpected input(s) 'persist-crendetials', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
|
Checks if number of files changed is acceptable
Unexpected input(s) 'persist-crendetials', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
|
Check for linting, formatting, and type errors
Unexpected input(s) 'persist-crendetials', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
|
Check for linting, formatting, and type errors
Unexpected input(s) 'persist-crendetials', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'ssh-user', 'persist-credentials', 'path', 'clean', 'filter', 'sparse-checkout', 'sparse-checkout-cone-mode', 'fetch-depth', 'fetch-tags', 'show-progress', 'lfs', 'submodules', 'set-safe-directory', 'github-server-url']
|