Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devcontainer #2429
base: develop
Are you sure you want to change the base?
Devcontainer #2429
Changes from 44 commits
fb46cd9
5e5b3ba
94483db
0d85405
3453a01
63db829
5af03b9
30a60c3
37ebcd9
294c279
ea8bbfd
c1efe35
0711a90
cd64b9b
978aa6e
af49f26
3e62b40
c2f0029
a0d736d
a35e64f
2e82058
56a7770
ffb745a
9a9f2c6
72ce9a1
b0a99c8
4765b00
6a7f6d4
6600ce2
63dcde3
034a06b
a69ed74
f84ec55
64d8f7d
682fdff
ac0ebee
91b90fc
6faf0c7
7023c8d
6723695
48d2845
413dc84
6c08aa4
36b1820
a4872ac
8709207
bf8b54b
fd7b6f7
b283c70
2f0bf4c
a412dd4
6cc696a
b868a11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you utilize the already existing
docker-compose.dev.yaml
file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was using the compose file outside the .decontainer.json file it was having some issues related to the project directory, that's why I used the file inside it. If I move the already existing file to that folder, developers can have issues, if they use docker for db.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify a version for the MongoDB image.
Using the
latest
tag can introduce breaking changes unexpectedly. It is recommended to specify a version to ensure stability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify a version for the Redis Stack Server image.
Using the
latest
tag can introduce breaking changes unexpectedly. It is recommended to specify a version to ensure stability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline at the end of the file.
The file is missing a newline at the end. Adding a newline is a best practice for POSIX compliance and to avoid potential issues with file concatenation.
+
Committable suggestion
Tools
yamllint