As mentioned by issue LMAX-Exchange#306 - Thread::onSpinWait should g…

…et called when we busy spin in SleepingWaitStrategy; But also all of the other wait strategies
Palmr · Oct 18, 2020 · 3345200 · 3345200
1 parent c1ea0d4
commit 3345200
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 0 deletions.
diff --git a/src/main/java/com/lmax/disruptor/LiteTimeoutBlockingWaitStrategy.java b/src/main/java/com/lmax/disruptor/LiteTimeoutBlockingWaitStrategy.java
@@ -1,5 +1,7 @@
 package com.lmax.disruptor;
 
+import com.lmax.disruptor.util.ThreadHints;
+
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 
@@ -52,6 +54,7 @@ public long waitFor(
         while ((availableSequence = dependentSequence.get()) < sequence)
         {
             barrier.checkAlert();
+            ThreadHints.onSpinWait();
         }
 
         return availableSequence;

diff --git a/src/main/java/com/lmax/disruptor/PhasedBackoffWaitStrategy.java b/src/main/java/com/lmax/disruptor/PhasedBackoffWaitStrategy.java
@@ -15,6 +15,8 @@
  */
 package com.lmax.disruptor;
 
+import com.lmax.disruptor.util.ThreadHints;
+
 import java.util.concurrent.TimeUnit;
 
 /**
@@ -130,6 +132,10 @@ else if (timeDelta > spinTimeoutNanos)
                 }
                 counter = SPIN_TRIES;
             }
+            else
+            {
+                ThreadHints.onSpinWait();
+            }
         }
         while (true);
     }

diff --git a/src/main/java/com/lmax/disruptor/SleepingWaitStrategy.java b/src/main/java/com/lmax/disruptor/SleepingWaitStrategy.java
@@ -15,6 +15,8 @@
  */
 package com.lmax.disruptor;
 
+import com.lmax.disruptor.util.ThreadHints;
+
 import java.util.concurrent.locks.LockSupport;
 
 /**
@@ -81,6 +83,7 @@ private int applyWaitMethod(final SequenceBarrier barrier, int counter)
         if (counter > 100)
         {
             --counter;
+            ThreadHints.onSpinWait();
         }
         else if (counter > 0)
         {

diff --git a/src/main/java/com/lmax/disruptor/TimeoutBlockingWaitStrategy.java b/src/main/java/com/lmax/disruptor/TimeoutBlockingWaitStrategy.java
@@ -1,5 +1,7 @@
 package com.lmax.disruptor;
 
+import com.lmax.disruptor.util.ThreadHints;
+
 import java.util.concurrent.TimeUnit;
 
 import static com.lmax.disruptor.util.Util.awaitNanos;
@@ -52,6 +54,7 @@ public long waitFor(
         while ((availableSequence = dependentSequence.get()) < sequence)
         {
             barrier.checkAlert();
+            ThreadHints.onSpinWait();
         }
 
         return availableSequence;

diff --git a/src/main/java/com/lmax/disruptor/YieldingWaitStrategy.java b/src/main/java/com/lmax/disruptor/YieldingWaitStrategy.java
@@ -16,6 +16,8 @@
 package com.lmax.disruptor;
 
 
+import com.lmax.disruptor.util.ThreadHints;
+
 /**
  * Yielding strategy that uses a Thread.yield() for {@link com.lmax.disruptor.EventProcessor}s waiting on a barrier
  * after an initially spinning.
@@ -60,6 +62,7 @@ private int applyWaitMethod(final SequenceBarrier barrier, int counter)
         else
         {
             --counter;
+            ThreadHints.onSpinWait();
         }
 
         return counter;