Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define in pyproject.toml Python 3.9 for ansible-core 2.14 #522

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

sebastianczech
Copy link
Contributor

Description

According to https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix, minimum version of Python for ansible-core 2.14 is Python 3.9.

Motivation and Context

Release action failed on step for documentation: https://github.com/PaloAltoNetworks/pan-os-ansible/actions/runs/7194066471/job/19593939780#step:5:108

How Has This Been Tested?

Code was checked locally by command: poetry add ansible-core^2.14

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech changed the title fix: Python 3.9 is minimum for Ansible core 2.14 fix: define in pyproject.toml Python 3.9 for Ansible core 2.14 Dec 13, 2023
@sebastianczech sebastianczech changed the title fix: define in pyproject.toml Python 3.9 for Ansible core 2.14 fix: define in pyproject.toml Python 3.9 for ansible-core 2.14 Dec 13, 2023
Copy link

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastianczech sebastianczech merged commit d4cd846 into develop Dec 14, 2023
16 checks passed
@sebastianczech sebastianczech deleted the fix-min-python-for-ansible-core-2-14 branch December 14, 2023 07:21
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
### [2.19.1](v2.19.0...v2.19.1) (2023-12-14)

### Bug Fixes

* define in pyproject.toml Python 3.9 for ansible-core 2.14 ([#522](#522)) ([d4cd846](d4cd846))
Copy link

🎉 This PR is included in version 2.19.1 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants