fix: Add new community argument for bgp_policy_rule #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually I just realized. This can't be released until pan-os-python releases or the module won't work :/ |
|
@adambaumeister I created a separate PR ( #547 ) for the EDA linting fix here on the following link not to wait for the pan-os-python release. |
alperenkose
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
@adambaumeister I think we can merge this now as I see there is a new release on pan-os-python ?
|
@alperenkose can you just quickly run your eyes over this one again and merge if all good? I believe it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflecting the changes made in this PR to pan-os-python: https://github.com/PaloAltoNetworks/pan-os-python/pull/535/files#diff-43b846942e01ef0d6442ff29e000fe176057b3a41979d9eb27fd7d549e6d6527
Adds the "action_community_modifier" argument to the panos_bgp_policy_rule.