From 42dc10733794d308cc76d44e96d017273833c2f5 Mon Sep 17 00:00:00 2001 From: Adam Baumeister <32481037+adambaumeister@users.noreply.github.com> Date: Thu, 15 Feb 2024 12:40:24 +1100 Subject: [PATCH 1/5] fix: Add new community argument for bgp_policy_rule --- plugins/modules/panos_bgp_policy_rule.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/plugins/modules/panos_bgp_policy_rule.py b/plugins/modules/panos_bgp_policy_rule.py index 471e0df67..37360c404 100644 --- a/plugins/modules/panos_bgp_policy_rule.py +++ b/plugins/modules/panos_bgp_policy_rule.py @@ -166,6 +166,10 @@ - remove-regex - append - overwrite + action_community_modifier + description: + - Modifier for the community action. Required if 'action_community_type' is set to 'append' or 'overwrite'. + type: str action_community_argument: description: - Argument to the action community value if needed. @@ -298,6 +302,7 @@ def setup_args(): type="str", choices=["none", "remove-all", "remove-regex", "append", "overwrite"], ), + action_community_modifier=dict(type="str"), action_community_argument=dict(type="str"), action_extended_community_type=dict(type="str"), action_extended_community_argument=dict(type="str"), @@ -359,6 +364,7 @@ def main(): "action_as_path_type": module.params["action_as_path_type"], "action_as_path_prepend_times": module.params["action_as_path_prepend_times"], "action_community_type": module.params["action_community_type"], + "action_community_modifier": module.params["action_community_modifier "], "action_community_argument": module.params["action_community_argument"], "action_extended_community_type": module.params[ "action_extended_community_type" From f262d2dc85b093c7be82416b9b84492732606354 Mon Sep 17 00:00:00 2001 From: Adam Baumeister Date: Thu, 15 Feb 2024 12:46:13 +1100 Subject: [PATCH 2/5] Fix bad docs format --- plugins/modules/panos_bgp_policy_rule.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/panos_bgp_policy_rule.py b/plugins/modules/panos_bgp_policy_rule.py index 37360c404..f28a58755 100644 --- a/plugins/modules/panos_bgp_policy_rule.py +++ b/plugins/modules/panos_bgp_policy_rule.py @@ -166,7 +166,7 @@ - remove-regex - append - overwrite - action_community_modifier + action_community_modifier: description: - Modifier for the community action. Required if 'action_community_type' is set to 'append' or 'overwrite'. type: str From 7f988da127219b8fa976eff6997e2deff2e77a58 Mon Sep 17 00:00:00 2001 From: Adam Baumeister Date: Thu, 15 Feb 2024 12:50:53 +1100 Subject: [PATCH 3/5] Fix docs again --- plugins/modules/panos_bgp_policy_rule.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/panos_bgp_policy_rule.py b/plugins/modules/panos_bgp_policy_rule.py index f28a58755..e6e0e4abc 100644 --- a/plugins/modules/panos_bgp_policy_rule.py +++ b/plugins/modules/panos_bgp_policy_rule.py @@ -166,7 +166,7 @@ - remove-regex - append - overwrite - action_community_modifier: + action_community_modifier: description: - Modifier for the community action. Required if 'action_community_type' is set to 'append' or 'overwrite'. type: str From 56269a157ad7d7f9dedb77bb44419760822c33cd Mon Sep 17 00:00:00 2001 From: Adam Baumeister Date: Thu, 15 Feb 2024 13:01:24 +1100 Subject: [PATCH 4/5] Fix docs linting in eda file --- extensions/eda/plugins/event_source/logs.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/extensions/eda/plugins/event_source/logs.py b/extensions/eda/plugins/event_source/logs.py index 42b475e8e..668e7acb9 100644 --- a/extensions/eda/plugins/event_source/logs.py +++ b/extensions/eda/plugins/event_source/logs.py @@ -16,6 +16,7 @@ port: 5000 type: decryption + """ # Copyright 2023 Palo Alto Networks, Inc @@ -59,6 +60,7 @@ async def status() -> web.Response: Returns ------- A web.Response object with status 200 and the text "up" returned by the function. + """ return web.Response(status=200, text="up") @@ -78,6 +80,7 @@ async def webhook(request: web.Request) -> web.Response: Returns ------- A web.Response object with status 200 and the status. + """ try: payload = await request.json() From 620a3ba97a529a84c665eacd53418f99b5e73080 Mon Sep 17 00:00:00 2001 From: Adam Baumeister <32481037+adambaumeister@users.noreply.github.com> Date: Thu, 24 Oct 2024 09:29:00 +1100 Subject: [PATCH 5/5] fix: typo in parameter dec --- plugins/modules/panos_bgp_policy_rule.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/panos_bgp_policy_rule.py b/plugins/modules/panos_bgp_policy_rule.py index e6e0e4abc..3325542c6 100644 --- a/plugins/modules/panos_bgp_policy_rule.py +++ b/plugins/modules/panos_bgp_policy_rule.py @@ -364,7 +364,7 @@ def main(): "action_as_path_type": module.params["action_as_path_type"], "action_as_path_prepend_times": module.params["action_as_path_prepend_times"], "action_community_type": module.params["action_community_type"], - "action_community_modifier": module.params["action_community_modifier "], + "action_community_modifier": module.params["action_community_modifier"], "action_community_argument": module.params["action_community_argument"], "action_extended_community_type": module.params[ "action_extended_community_type"