Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update SUPPORT.md #544

Merged
merged 2 commits into from
Feb 20, 2024
Merged

chore: Update SUPPORT.md #544

merged 2 commits into from
Feb 20, 2024

Conversation

adambaumeister
Copy link
Collaborator

Updating support.md file with new legal verbiage.

@alperenkose for docs updates like this, is it safe to simply commit them to the main branch here with a proper commit message? I didn't want to trigger a release accidentally.

@adambaumeister adambaumeister marked this pull request as ready for review February 16, 2024 00:03
@alperenkose
Copy link
Collaborator

@adambaumeister According to the .releaserc.json file we are using the "conventionalcommits" and docs: prefix shouldn't trigger a release as I understand from this but I can test it in a fork and confirm.

SUPPORT.md Outdated
repository (at https://github.com/PaloAltoNetworks) or sites other than our
official Downloads page on https://support.paloaltonetworks.com are provided
under the best effort policy.
This template/script/solution is released “as-is”, with no warranty and no support. These should be seen as community supported and Palo Alto Networks may contribute its expertise at its discretion. Palo Alto Networks, including through its Authorized Support Centers (ASC) partners and backline support options, will not provide technical support or help in using or troubleshooting this template/script/solution. The underlying product used by this template/script/solution will still be supported in accordance with the product’s applicable support policy and the customer’s entitlements.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checks fail for the qoutes, asking for using plain ascii qoutes. I will update this.
https://docs.ansible.com/ansible-core/devel/dev_guide/testing/sanity/no-smart-quotes.html

@alperenkose
Copy link
Collaborator

@adambaumeister I have tested this on a fork repo, with the docs: commit type it doesn't produce a new release. We can commit on the main and merge to develop for this kind of cases.

github-release-test

@alperenkose alperenkose merged commit 8898abd into develop Feb 20, 2024
14 of 16 checks passed
@alperenkose alperenkose deleted the chore-update-support-md branch February 20, 2024 07:11
Copy link

🎉 This PR is included in version 2.20.0 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants