-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle uuid and entry-style list resources #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklimonda-cl
changed the base branch from
main
to
feat-render-resource-second-part
August 6, 2024 15:43
kklimonda-cl
force-pushed
the
feat-security-group-rules-plural
branch
3 times, most recently
from
August 8, 2024 06:04
9fda4e7
to
9cd495e
Compare
migara
force-pushed
the
feat-render-resource-second-part
branch
from
August 8, 2024 12:53
e84eeeb
to
aea8772
Compare
migara
approved these changes
Aug 8, 2024
kklimonda-cl
force-pushed
the
feat-security-group-rules-plural
branch
from
August 8, 2024 15:02
c0695f5
to
dede5f1
Compare
kklimonda-cl
force-pushed
the
feat-security-group-rules-plural
branch
2 times, most recently
from
August 8, 2024 16:50
0725782
to
6ab060d
Compare
kklimonda-cl
force-pushed
the
feat-security-group-rules-plural
branch
from
August 9, 2024 09:34
90c9c52
to
a086742
Compare
kklimonda-cl
force-pushed
the
feat-security-group-rules-plural
branch
from
August 9, 2024 09:37
a086742
to
ba836d2
Compare
kklimonda-cl
changed the title
Manage UUID-style resources as lists in terraform
Properly handle uuid and entry-style list resources
Aug 9, 2024
kklimonda-cl
force-pushed
the
feat-security-group-rules-plural
branch
from
August 9, 2024 13:40
c086fdb
to
3c92641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for resource lists, both uuid-style lists (
panos_security_policy
,pan_security_policy_rules
) and entry-style lists (panos_address_objects
).Current status:
What's missing:
panos_security_policy_rules
Improvements:
I think core logic of create, update, read and delete can be moved into a generic structure - doing this would make it possible to properly test it with a mock client and specifier. Usage from generated code would be a bit like that:
Bugs: