just return nil filtering group if parse string is nil

PaloAltoNetworks · Apr 8, 2024 · 216d850 · 216d850
1 parent a5279df
commit 216d850
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/filtering/parse.go b/filtering/parse.go
@@ -14,7 +14,7 @@ func Parse(s string, quote string) (*Group, error) {
 	} else if quote == "&" || quote == "|" || quote == "(" || quote == ")" || quote == " " || quote == `\` || quote == "!" || quote == "." || quote == "<" || quote == ">" || quote == "=" || quote == "-" || quote == "_" {
 		return nil, fmt.Errorf("quote character cannot be a reserved character")
 	} else if s == "" {
-		return nil, fmt.Errorf("logic string is empty")
+		return nil, nil
 	}
 
 	var ch rune

diff --git a/filtering/parse_test.go b/filtering/parse_test.go
@@ -932,7 +932,6 @@ func TestParseReturnsError(t *testing.T) {
 		"foobar",
 		"(",
 		")",
-		"",
 	}
 
 	for _, s := range checks {
@@ -966,3 +965,12 @@ func TestParseWithInvalidQuoteReturnsError(t *testing.T) {
 		}
 	}
 }
+
+func TestParseEmptyString(t *testing.T) {
+	resp, err := Parse("", `"`)
+	if err != nil {
+		t.Fatalf("parse empty string error: %s", err)
+	} else if resp != nil {
+		t.Fatalf("parse empty string has non-nil group")
+	}
+}