Add removal reason to EntityRemoveFromWorldEvent #10149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonytheMacaroni
force-pushed
the
removal-reason
branch
2 times, most recently
from
7c58493 to
39b9d10
Compare
kennytv
previously approved these changes
Jan 24, 2024
TonytheMacaroni
force-pushed
the
removal-reason
branch
2 times, most recently
from
68721e7 to
80d564f
Compare
TonytheMacaroni
force-pushed
the
removal-reason
branch
from
80d564f to
1afe820
Compare
NoahvdAa
previously approved these changes
Mar 3, 2024
lynxplay
dismissed stale reviews from kennytv and NoahvdAa
We should expose upstreams resasons here too.
|
Given upstream has merged into an entity remove from world event, can you expand this PR to include the new reasons? Would be fixing #10280 |
|
Yes please! |
TonytheMacaroni
force-pushed
the
removal-reason
branch
2 times, most recently
from
abb4c83 to
94119a3
Compare
|
Updated the PR to include the causes upstream added. Also moved the primary event call to |
TonytheMacaroni
force-pushed
the
removal-reason
branch
from
94119a3 to
0790c7e
Compare
TonytheMacaroni
force-pushed
the
removal-reason
branch
from
0790c7e to
d073da4
Compare
TonytheMacaroni
force-pushed
the
removal-reason
branch
from
d073da4 to
6cf0de6
Compare
|
Rebased. Also removed some unneeded diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a removal reason to
EntityRemoveFromWorldEvent. TheRemovalReasonenum mirrors the NMSEntity.RemovalReason, except that the methodsshouldDestroy/shouldSaveare renamed towillDestroy/willSave. Due to the chunk system rewrite, unloaded entities are not set as removed withRemovalReason.UNLOAD_TO_CHUNK, so currently if the removal reason is not set and the entity is inaccessible, it'll default toRemovalReason.UNLOAD_TO_CHUNKas the removal reason.