distinguish between null and empty map in API #10829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
approved these changes
May 30, 2024
Machine-Maker
force-pushed
the
fix/meta-attributes
branch
from
e9de6d4 to
b9613cb
Compare
lynxplay
approved these changes
Jun 1, 2024
lynxplay
force-pushed
the
fix/meta-attributes
branch
from
b9613cb to
4673bc2
Compare
Owen1212055
approved these changes
Jul 15, 2024
Machine-Maker
force-pushed
the
fix/meta-attributes
branch
from
4673bc2 to
534e457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we distinguish between null and empty when applying attributes to an itemstack, we also have to make a distinction in the full map setter. Calling the setter with
null, shouldn't create an empty attribute modifier map.