Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default requires and permission methods to BasicCommand #11047

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

kennytv
Copy link
Member

@kennytv kennytv commented Jul 9, 2024

Alternative to #11046; does not deprecate the existing methods and instead opts for a simpler solution

@kennytv kennytv requested a review from a team as a code owner July 9, 2024 13:07
@MiniDigger
Copy link
Member

I still think attaching a perm node should be mandatory. We need to actively discourage using manual perm checks for root commands, since doing that over using this new method will still send the command, so players can tab complete it.
A part of me always dies whenever I see people installing tab block plugins or straight up disable tab complete in order to hide commands players don't have permission to run but still see in tab completion.
In my ideal world every root command has a perm node attached to it and it a command should be used by e everyone by default the permission to that command should just be granted by default, either by registering it in the plugin.yml or by registering it in code.

@kennytv kennytv force-pushed the basiccommand-basicpermission branch from 508f3e6 to 4b464a9 Compare July 11, 2024 19:01
@kennytv kennytv force-pushed the basiccommand-basicpermission branch from 4b464a9 to 91ab08a Compare July 12, 2024 16:05
@kennytv kennytv force-pushed the basiccommand-basicpermission branch from 91ab08a to eb8e4f4 Compare July 12, 2024 16:09
@kennytv kennytv force-pushed the basiccommand-basicpermission branch from 7f6ad6e to eb8e4f4 Compare July 14, 2024 12:00
@kennytv kennytv merged commit 34a2917 into master Jul 14, 2024
9 checks passed
@kennytv kennytv deleted the basiccommand-basicpermission branch July 14, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants