Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ItemType#getItemRarity #11049

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

Machine-Maker
Copy link
Member

Closes #11040


Adds a nullable getItemRarity to ItemType. I'm not gonna bother adding it to Material because we have one with a conflicting name already (a deprecated one using our deprecated ItemRarity type).

@Machine-Maker Machine-Maker requested a review from a team as a code owner July 10, 2024 01:38
@lynxplay lynxplay force-pushed the feature/ItemType#getItemRarity branch from 07a8bb0 to a5469f8 Compare July 15, 2024 14:31
@lynxplay lynxplay merged commit 05e5865 into PaperMC:master Jul 15, 2024
3 checks passed
@Machine-Maker Machine-Maker deleted the feature/ItemType#getItemRarity branch August 28, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Items do not have rarity and rarity disappears when set.
3 participants