Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require author and title to be set on signed book meta #11068

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

Lulu13022002
Copy link
Contributor

Closes #11067

Fix a regression in 4d20922 and make pages optional too while still keeping the author and title.

@Lulu13022002 Lulu13022002 requested a review from a team as a code owner July 13, 2024 18:17
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot test, but diff looks good.

Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good after testing

@lynxplay lynxplay merged commit 99ae7bb into PaperMC:master Jul 14, 2024
4 checks passed
@Lulu13022002 Lulu13022002 deleted the fix/book-meta branch December 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Written books with pages require author/title
3 participants