Add CrafterCraftItemEvent #11082
Merged
Add CrafterCraftItemEvent #11082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
approved these changes
Jul 15, 2024
lynxplay
force-pushed
the
feature/crafter-craft-event
branch
from
bdd7810 to
2d64f83
Compare
Owen1212055
approved these changes
Jul 15, 2024
|
Unfortunately, in all of their wisdom, upstream has begun work on this event to. I'll try my best to ensure all methods present on this PR will be in the upstream version too. |
lynxplay
force-pushed
the
feature/crafter-craft-event
branch
from
2d64f83 to
39883ac
Compare
kennytv
approved these changes
Jul 18, 2024
Adds an event fired when the crafter crafts an item. The event only exposes the recipe and the potential result for event modifications.
lynxplay
force-pushed
the
feature/crafter-craft-event
branch
from
8ea242e to
f7851eb
Compare
lynxplay
force-pushed
the
feature/crafter-craft-event
branch
from
7b9a2b5 to
3161d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event fired when the crafter crafts an item. The event only exposes the recipe and the potential result for event modifications.
The PR does not contain a preparation related event along the lines of PrepareItemCraftEvent, as exposing the relative players in such an event is out of scope of the PR. It is also not necessary for plugins to prevent crafting specific items.
Future improvements to this event may include boolean flags to prevent items from being consumed, but this is also out of scope for the PR.