Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument for FinePosition to brig API #11094

Merged

Conversation

Machine-Maker
Copy link
Member

No description provided.

@Machine-Maker Machine-Maker requested a review from a team as a code owner July 16, 2024 23:28
@lynxplay lynxplay force-pushed the feature/fine-pos-argument branch from 0c87e1b to d39f750 Compare July 26, 2024 12:04
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, overload is up to subjective opinion of the merger.

@Machine-Maker Machine-Maker force-pushed the feature/fine-pos-argument branch from d39f750 to bb29f63 Compare July 28, 2024 18:18
@Machine-Maker Machine-Maker merged commit f82bea6 into PaperMC:master Jul 28, 2024
3 checks passed
@Machine-Maker Machine-Maker deleted the feature/fine-pos-argument branch July 28, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants