Migrate ArmorStand meta to using entity tag #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
added
the
build-pr-jar
electronicboy
force-pushed
the
fixes/armor-meta
branch
from
61f2c73 to
3173d18
Compare
|
Hey, is there any update on this pull request? |
TehBrian
reviewed
Aug 15, 2024
Yup, it is. |
This was referenced Aug 15, 2024
Closed
Machine-Maker
approved these changes
Aug 16, 2024
lynxplay
force-pushed
the
fixes/armor-meta
branch
from
60fe82f to
b96f801
Compare
Our handling of this class causes some headaches due to ItemMeta being lossy, we can double patch this by properly storing the data we care about, there is still some stuff to be addressed, i.e. we really should ensure that the entity tag is stored to the tag properly
lynxplay
force-pushed
the
fixes/armor-meta
branch
from
14aa072 to
1fdf21d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our handling of this class causes some headaches due to ItemMeta being lossy, we can double patch this by properly storing the data we care about, there is still some stuff to be addressed, i.e. we really should ensure that the entity tag is stored to the tag properly
TODO: actually, we should just serialise the entity tag directly as b64
Download the paperclip jar for this pull request: paper-11107.zip