Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CraftComplexRecipe extend CraftingRecipe #11114

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

lynxplay
Copy link
Contributor

@lynxplay lynxplay commented Jul 19, 2024

Closes: #11116


Download the paperclip jar for this pull request: paper-11114.zip

@lynxplay lynxplay requested a review from a team as a code owner July 19, 2024 15:12
kennytv
kennytv previously approved these changes Jul 19, 2024
@lynxplay lynxplay force-pushed the bugfix/crafter-craft-event-recipe branch from 7a076a3 to 4096934 Compare July 19, 2024 15:38
Copy link
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nms.CustomRecipe#toBukkitRecipe, set the category and group of the recipe

@lynxplay
Copy link
Contributor Author

Done, also removed some diff not needed.

@lynxplay lynxplay force-pushed the bugfix/crafter-craft-event-recipe branch from 2340c99 to 42f8ca6 Compare July 19, 2024 17:04
@lynxplay lynxplay force-pushed the bugfix/crafter-craft-event-recipe branch from 42f8ca6 to d90a343 Compare July 19, 2024 17:09
@lynxplay lynxplay added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Jul 19, 2024
@lynxplay lynxplay changed the title Support all types of recipes in CrafterEvent Make CraftComplexRecipe extend CraftingRecipe Jul 19, 2024
@lynxplay lynxplay force-pushed the bugfix/crafter-craft-event-recipe branch from 75a1f40 to a3f28c6 Compare July 19, 2024 17:24
@lynxplay lynxplay merged commit 968bdeb into PaperMC:master Jul 19, 2024
3 checks passed
@lynxplay lynxplay deleted the bugfix/crafter-craft-event-recipe branch July 19, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Crafter crafting level 3 Rockets istantly crashes the server
3 participants