-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CraftComplexRecipe extend CraftingRecipe #11114
Merged
lynxplay
merged 5 commits into
PaperMC:master
from
lynxplay:bugfix/crafter-craft-event-recipe
Jul 19, 2024
Merged
Make CraftComplexRecipe extend CraftingRecipe #11114
lynxplay
merged 5 commits into
PaperMC:master
from
lynxplay:bugfix/crafter-craft-event-recipe
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
previously approved these changes
Jul 19, 2024
lynxplay
force-pushed
the
bugfix/crafter-craft-event-recipe
branch
from
July 19, 2024 15:38
7a076a3
to
4096934
Compare
Machine-Maker
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In nms.CustomRecipe#toBukkitRecipe, set the category and group of the recipe
Done, also removed some diff not needed. |
Machine-Maker
approved these changes
Jul 19, 2024
lynxplay
force-pushed
the
bugfix/crafter-craft-event-recipe
branch
from
July 19, 2024 17:04
2340c99
to
42f8ca6
Compare
lynxplay
force-pushed
the
bugfix/crafter-craft-event-recipe
branch
from
July 19, 2024 17:09
42f8ca6
to
d90a343
Compare
lynxplay
added
the
build-pr-jar
Enables a workflow to build Paperclip jars on the pull request.
label
Jul 19, 2024
lynxplay
changed the title
Support all types of recipes in CrafterEvent
Make CraftComplexRecipe extend CraftingRecipe
Jul 19, 2024
lynxplay
force-pushed
the
bugfix/crafter-craft-event-recipe
branch
from
July 19, 2024 17:24
75a1f40
to
a3f28c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11116
Download the paperclip jar for this pull request: paper-11114.zip