Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci skip] fix run dev #9797

Closed
wants to merge 1 commit into from
Closed

[ci skip] fix run dev #9797

wants to merge 1 commit into from

Conversation

MiniDigger
Copy link
Member

@MiniDigger MiniDigger commented Oct 5, 2023 •
edited
Loading

🤷‍♂️

@MiniDigger MiniDigger requested a review from a team as a code owner October 5, 2023 16:58
@MiniDigger MiniDigger mentioned this pull request Oct 5, 2023
Closed
@MiniDigger
Copy link
Member Author

(also turned filterpatches back on)

jpenilla
jpenilla requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@jpenilla jpenilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should fix FilterProjectDir on windows instead

@MiniDigger
Copy link
Member Author

PaperMC/paperweight#214

@MiniDigger MiniDigger closed this Oct 5, 2023
@MiniDigger MiniDigger deleted the fix/run-dev branch October 5, 2023 17:19
@Leguan16
Copy link
Contributor

Leguan16 commented Oct 5, 2023

Shouldn't this happen anyway?

-tasks.withType<io.papermc.paperweight.tasks.RebuildGitPatches> {
-    filterPatches.set(false)
-}
+// tasks.withType<io.papermc.paperweight.tasks.RebuildGitPatches> {
+//     filterPatches.set(false)    
+// }

@MiniDigger
Copy link
Member Author

#9799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpenilla jpenilla jpenilla requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiniDigger @Leguan16 @jpenilla