Skip to content

Commit

Permalink
fix(proxy-provider-manager): handle setting falsy value
Browse files Browse the repository at this point in the history
Co-authored-by: Jerry Laloan <jerrylaloan@users.noreply.github.com>
  • Loading branch information
alexandre-abrioux and jerrylaloan committed Jan 30, 2024
1 parent 1bc5e99 commit 846c678
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { ProxyProviderManager } from './proxy-provider-manager';
import { globalClsService } from '../cls-service.globals';

describe('Proxy provider manager', () => {
it('proxy should allow setting falsy value', async () => {
const clsService = globalClsService;
const symbol = Symbol('testSymbol');
const proxyProvider = ProxyProviderManager.createProxyProvider({
provide: symbol,
type: 'object',
useFactory: () => ({
booleanTest: true,
}),
});
const proxy = proxyProvider.useFactory();
await clsService.run(async () => {
await ProxyProviderManager.resolveProxyProviders();
expect(proxy.booleanTest).toBe(true);
proxy.booleanTest = false;
expect(proxy.booleanTest).toBe(false);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export class ProxyProviderManager {
return getProvider()[prop];
},
set(_, prop, value) {
return (getProvider()[prop] = value);
return Reflect.set(getProvider(), prop, value);
},
ownKeys() {
return Reflect.ownKeys(getProvider());
Expand Down

0 comments on commit 846c678

Please sign in to comment.