feat: add @nestjs-cls/transactional-adapter-pg-promise #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Papooch your feedback is very welcome! |
Papooch
reviewed
Jan 24, 2024
packages/transactional-adapters/transactional-adapter-pg-promise/package.json
Outdated
Show resolved
Hide resolved
Papooch
requested changes
Jan 24, 2024
packages/transactional-adapters/transactional-adapter-pg-promise/package.json
Outdated
Show resolved
Hide resolved
...tional-adapters/transactional-adapter-pg-promise/src/lib/transactional-adapter-pg-promise.ts
Outdated
Show resolved
Hide resolved
...tional-adapters/transactional-adapter-pg-promise/src/lib/transactional-adapter-pg-promise.ts
Outdated
Show resolved
Hide resolved
...onal-adapters/transactional-adapter-pg-promise/test/transactional-adapter-pg-promise.spec.ts
Outdated
Show resolved
Hide resolved
Papooch
reviewed
Jan 24, 2024
...tional-adapters/transactional-adapter-pg-promise/src/lib/transactional-adapter-pg-promise.ts
Outdated
Show resolved
Hide resolved
Papooch
reviewed
Jan 24, 2024
...tional-adapters/transactional-adapter-pg-promise/src/lib/transactional-adapter-pg-promise.ts
Outdated
Show resolved
Hide resolved
packages/transactional-adapters/transactional-adapter-pg-promise/package.json
Outdated
Show resolved
Hide resolved
sam-artuso
force-pushed
the
feat/transactional-adapter-pg-promise
branch
from
aa68751
to
5239af0
Compare
Papooch
force-pushed
the
feat/transactional-adapter-pg-promise
branch
from
428df06
to
b018377
Compare
|
@sam-artuso Sorry, I accidentally clicked the update branch button instead of allow tests which rebased your changes. You might need to force-push again to clean this up. Btw, could you also please add documentation to |
sam-artuso
force-pushed
the
feat/transactional-adapter-pg-promise
branch
4 times, most recently
from
ad4b375
to
53847fc
Compare
Papooch
reviewed
Jan 29, 2024
...onal-adapters/transactional-adapter-pg-promise/test/transactional-adapter-pg-promise.spec.ts
Outdated
Show resolved
Hide resolved
...onal-adapters/transactional-adapter-pg-promise/test/transactional-adapter-pg-promise.spec.ts
Outdated
Show resolved
Hide resolved
...onal-adapters/transactional-adapter-pg-promise/test/transactional-adapter-pg-promise.spec.ts
Outdated
Show resolved
Hide resolved
docs/docs/06_plugins/01_available-plugins/01-transactional/index.md
Outdated
Show resolved
Hide resolved
sam-artuso
force-pushed
the
feat/transactional-adapter-pg-promise
branch
from
d3e40d5
to
91d385a
Compare
Papooch
changed the title
Papooch
reviewed
Jan 29, 2024
...onal-adapters/transactional-adapter-pg-promise/test/transactional-adapter-pg-promise.spec.ts
Outdated
Show resolved
Hide resolved
Papooch
approved these changes
Jan 29, 2024
|
Thanks! |
|
When do you think you'll release this? |
|
I'll most likely publish it later today with some other changes I'm working on. |
|
It has now been published 🚀 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nestjs-cls/transactional adapter for pg-promise.
Two caveats:
pg-promiseis Postgres-specific, so the tests requiredocker-compose.any.Apart from these 2 points, my adapter is the same as the those for Knex and Prisma.