Fix an issue CPU threshold (#234)

- Fixed an issue with the CPU threshold that was added twice to the orchestrator
Parallels · Nov 11, 2024 · 1d26319 · 1d26319
1 parent b4e98f4
commit 1d26319
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/orchestrator/create_host_virtual_machine.go b/src/orchestrator/create_host_virtual_machine.go
@@ -226,10 +226,10 @@ func (s *OrchestratorService) validateHost(host data_models.OrchestratorHost, ar
 		return false, apiError
 	}
 
-	systemCPUThreshold := int64(1)
-	systemMemoryThreshold := float64(1024)
-	availableCpus := host.Resources.TotalAvailable.LogicalCpuCount - systemCPUThreshold
-	availableMemory := host.Resources.TotalAvailable.MemorySize - systemMemoryThreshold
+	// We will trust that the host has the reserved cpus setup correctly
+	// otherwise we would potentially go above the reserved cpus
+	availableCpus := host.Resources.TotalAvailable.LogicalCpuCount
+	availableMemory := host.Resources.TotalAvailable.MemorySize
 
 	// Checking for the maximum number of Apple VMs
 	if strings.EqualFold(specs.Type, "macvm") {

diff --git a/src/serviceprovider/parallelsdesktop/main.go b/src/serviceprovider/parallelsdesktop/main.go
@@ -1836,7 +1836,7 @@ func (s *ParallelsService) GetHardwareUsage(ctx basecontext.ApiContext) (*models
 	result.Total.DiskSize = systemInfo.DiskSize - systemInfo.FreeDiskSize
 
 	result.TotalAvailable = &models.SystemUsageItem{}
-	result.TotalAvailable.DiskSize = result.Total.DiskSize - result.SystemReserved.DiskSize - result.TotalReserved.DiskSize - result.TotalInUse.DiskSize
+	result.TotalAvailable.DiskSize = systemInfo.FreeDiskSize
 	result.TotalAvailable.MemorySize = result.Total.MemorySize - result.SystemReserved.MemorySize - result.TotalInUse.MemorySize
 	result.TotalAvailable.LogicalCpuCount = result.Total.LogicalCpuCount - result.SystemReserved.LogicalCpuCount - result.TotalInUse.LogicalCpuCount