V0.8.0 hotfix (#166)

* hotfix for version 0.8.0

- reducing the default refresh time for the PD machines to 15 seconds
- fixed the issue with the documentation
- updated documentation

* further fixes to the refresh of machines in the background

* further fixes to the refresh

* fixes to the automation pipeline

.github/workflows/automation.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Assign Security Label
         if: ${{ contains(github.event.issue.title, 'security')}}
         env:
-            GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+            GH_TOKEN: ${{ secrets.GH_PAT }}
         run: |
           gh issue edit ${{ github.event.issue.number }} --add-label "security"
   assign-security-pr:
@@ -30,7 +30,7 @@ jobs:
       - name: Assign Security Label
         if: ${{ github.event.pull_request.draft == false && contains(github.event.pull_request.title, 'security')}}
         env:
-            GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+            GH_TOKEN: ${{ secrets.GH_PAT }}
         run: |
           gh pr edit ${{ github.event.number }} --add-label "security"
   assign-triage-pr:
@@ -67,7 +67,7 @@ jobs:
       - name: Assign Security Label
         if: ${{ github.event.pull_request.draft == false }}
         env:
-            GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+            GH_TOKEN: ${{ secrets.GH_PAT }}
         run: |
           ${{ github.event.sender.name  }}
           ${{ github.event.pull_request.author_association }}

docs/_includes/head.html

@@ -21,12 +21,4 @@
     {%- include google-analytics.html -%}
   {%- endif -%}
   {%- include head-scripts.html -%}
-  <h1>Parallels Desktop DevOps Service</h1>
-  <h2>Architecture</h2>
-  <h2>CI/CD</h2>
-  <h2>Orchestrator</h2>
-  <h2>Provisioning</h2>
-  <h2>Security</h2>
-  <h2>virtualization</h2>
-  <h2>Networking</h2>
 </head>

docs/docs/getting-started/configuration.md

@@ -39,10 +39,10 @@ The root object of the configuration file is the environment object, which conta
 | ROOT_PASSWORD | The root password that will be used to update the root password of the virtual machine | |
 | DATABASE_FOLDER_ENV_VAR | The folder where the database will be stored | /User/Folder/.prl-devops-service |
 | DATABASE_NUMBER_BACKUP_FILES | The number of backup files that the database will keep | 10 |
-| DATABASE_BACKUP_INTERVAL_MINUTES | The interval in minutes that the database will be backed up | 120 |
-| DATABASE_SAVE_INTERVAL_MINUTES | The interval in minutes that the database will be saved | 5 |
+| DATABASE_BACKUP_INTERVAL_MINUTES | The interval in minutes that the database will be backed up in minutes | 120 minutes |
+| DATABASE_SAVE_INTERVAL_MINUTES | The interval in minutes that the database will be saved in minytes | 5 minutes |
 | CATALOG_CACHE_FOLDER | The folder where the catalog cache will be stored | /User/Folder/.prl-devops-service/catalog |
-| PARALLELS_DESKTOP_REFRESH_INTERVAL | The interval in seconds that the service will refresh the Parallels Desktop virtual machines | 1 |
+| PARALLELS_DESKTOP_REFRESH_INTERVAL | The interval in seconds that the service will refresh the Parallels Desktop virtual machines in seconds | 15 seconds |
 
 
 ### Rest API

src/config/main.go

@@ -297,10 +297,10 @@ func (c *Config) DbSaveInterval() time.Duration {
 func (c *Config) ParallelsRefreshInterval() time.Duration {
 	interval := c.GetIntKey(constants.PARALLELS_DESKTOP_REFRESH_INTERVAL_ENV_VAR)
 	if interval == 0 {
-		return 30 * time.Second
+		return 20 * time.Second
 	}
 
-	return time.Duration(interval) * time.Minute
+	return time.Duration(interval) * time.Second
 }
 
 func (c *Config) RootFolder() (string, error) {

src/serviceprovider/parallelsdesktop/main.go

@@ -32,11 +32,12 @@ import (
 var (
 	globalParallelsService *ParallelsService
 	logger                 = common.Logger
-	cachedLocalVms         []models.ParallelsVM
 )
 
 type ParallelsService struct {
 	ctx              basecontext.ApiContext
+	refreshStarted   bool
+	cachedLocalVms   []models.ParallelsVM
 	executable       string
 	serverExecutable string
 	Info             *models.ParallelsDesktopInfo
@@ -47,10 +48,6 @@ type ParallelsService struct {
 }
 
 func Get(ctx basecontext.ApiContext) *ParallelsService {
-	if cachedLocalVms == nil {
-		cachedLocalVms = make([]models.ParallelsVM, 0)
-	}
-
 	if globalParallelsService != nil {
 		return globalParallelsService
 	}
@@ -59,7 +56,13 @@ func Get(ctx basecontext.ApiContext) *ParallelsService {
 
 func New(ctx basecontext.ApiContext) *ParallelsService {
 	globalParallelsService = &ParallelsService{
-		ctx: ctx,
+		refreshStarted: false,
+		ctx:            ctx,
+	}
+
+	if globalParallelsService.cachedLocalVms == nil {
+		globalParallelsService.cachedLocalVms = make([]models.ParallelsVM, 0)
+		globalParallelsService.refreshCacheVms(ctx)
 	}
 
 	if globalParallelsService.FindPath() == "" {
@@ -275,13 +278,20 @@ func (s *ParallelsService) IsLicensed() bool {
 }
 
 func (s *ParallelsService) refreshCacheVms(ctx basecontext.ApiContext) {
+	if s.refreshStarted {
+		return
+	}
+
 	go func() {
+		s.refreshStarted = true
 		for {
+			ctx.LogInfof("Waiting %s to refresh VM cache", config.Get().ParallelsRefreshInterval())
 			time.Sleep(config.Get().ParallelsRefreshInterval())
 			var err error
-			if cachedLocalVms, err = s.GetVms(ctx); err != nil {
+			if s.cachedLocalVms, err = s.GetVms(ctx); err != nil {
 				ctx.LogErrorf("Error refreshing VM cache: %v", err)
 			}
+
 			ctx.LogInfof("VM cache refreshed")
 		}
 	}()
@@ -317,13 +327,13 @@ func (s *ParallelsService) GetCachedVms(ctx basecontext.ApiContext, filter strin
 	ctx.LogInfof("Getting all VMs for all users with cache")
 	var systemMachines []models.ParallelsVM
 	var err error
-	if len(cachedLocalVms) > 0 {
-		systemMachines = cachedLocalVms
+	if len(s.cachedLocalVms) > 0 {
+		systemMachines = s.cachedLocalVms
 	} else {
 		if systemMachines, err = s.GetVms(ctx); err != nil {
 			return nil, err
 		}
-		cachedLocalVms = systemMachines
+		s.cachedLocalVms = systemMachines
 		s.refreshCacheVms(ctx)
 	}
 
@@ -348,7 +358,7 @@ func (s *ParallelsService) GetVmsSync(ctx basecontext.ApiContext, filter string)
 		return nil, err
 	}
 
-	cachedLocalVms = vms
+	s.cachedLocalVms = vms
 	systemMachines = vms
 
 	dbFilter, err := data.ParseFilter(filter)