Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 271124-1 #69

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Hotfix 271124-1 #69

merged 1 commit into from
Nov 27, 2024

Conversation

cjlapao
Copy link
Contributor

@cjlapao cjlapao commented Nov 27, 2024

Description

  • Fixed some issues with the ensure processes where we could get nil pointers
  • Added a new process to delete vms that were created but the creation process failed
  • Added the enforce of the flag force_changes on the create where it will delete vms if the pre-exist
  • Fixed some issues with the getVms method where the id was not being escaped
  • Added a fix for the intel macs where we now add the user to the sudoers list if not present
  • Added a fix where if PD failed to install we would get an error with dependencies

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run linting on my code
  • I have run tests that prove my fix is effective or that my feature works
  • I have updated the CHANGELOG.md file accordingly

- Fixed some issues with the ensure processes where we could get nil pointers
- Added a new process to delete vms that were created but the creation process failed
- Added the enforce of the flag force_changes on the create where it will delete vms if the pre-exist
- Fixed some issues with the getVms method where the id was not being escaped
- Added a fix for the intel macs where we now add the user to the sudoers list if not present
- Added a fix where if PD failed to install we would get an error with dependencies
@cjlapao cjlapao merged commit 5244f34 into main Nov 27, 2024
8 checks passed
@cjlapao cjlapao deleted the cjlapao/hotfix/271124-1 branch November 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant