#10 driver path update #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunglinn
requested changes
Jun 19, 2023
| @@ -15,7 +15,7 @@ | |||
|
|
|||
|
|
|||
|
|
|||
| def get_html(url, driver_path=r"C:\Users\tungl\Downloads\chromedriver_win32\chromedriver"): | |||
| def get_html(url, driver_path=r"https://github.com/ParkingReformNetwork/parking-requirement-database.git"): | |||
There was a problem hiding this comment.
The default chrome driver name is 'chromedriver', so please change the path to that.
Also, add a note in README.md about where to place the chrome driver. If the path is 'chromedriver', then it has to be placed in the same folder as this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #10