Migrate NUnit assertions to the constraint model in preparation of the NUnit 4 upgrade #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
nunit-assertions-migration
branch
from
aac0640
to
2fd3cc8
Compare
danielmarbach
commented
Aug 19, 2024
| @@ -17,7 +17,8 @@ | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" /> | |||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> | |||
| <PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="9.1.1" GeneratePathProperty="true" /> | |||
| <PackageReference Include="Nunit" Version="3.14.0" /> | |||
| <PackageReference Include="NUnit" Version="3.14.0" /> | |||
There was a problem hiding this comment.
It was crucial to switch from Nunit to NUnit making sure the script catches all references.
danielmarbach
force-pushed
the
nunit-assertions-migration
branch
from
2fd3cc8
to
302bcc4
Compare
lailabougria
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all changes related to assertion model according to the constraint assertion model.
Using a script, we apply all assertion rules provided by the NUnit.Analyzers package. In addition, some manual interventions are done when applicable.
Plan of action