Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Required features for Curios #84

Open
9 of 15 tasks
ZNixian opened this issue Jun 16, 2020 · 6 comments
Open
9 of 15 tasks

Required features for Curios #84

ZNixian opened this issue Jun 16, 2020 · 6 comments
Labels
features needed for mod A list of things needed for a specific Forge mod to work

Comments

@ZNixian
Copy link
Member

ZNixian commented Jun 16, 2020

CurseForge

This mod is interesting largely because it's required for Botania (though needless to say that's some ways off), however numerous other mods also use it.

These are all the things I could find that it needs to (after stubbing them out) reach the main menu. It then crashes while loading in from @CapabilityInject not being implemented. As such it likely uses other features, and I'll update this once it's implemented.

patchwork-gui (famous/VFMADD said in Discord they'd be working on these)

  • SlotItemHandler
  • ItemStackHandler
  • IItemHandler
  • IContainerFactory
  • IForgeContainerFactory
  • ItemTooltipEvent

patchwork-events-entity

patchwork-events-lifecycle (probably the best place for this):

Unknown module/other:

  • EntityRenderDispatcher.getSkinMap must be added
  • The CapabilityInject annotation

Bugs:

Access widening:

  • Screens.Provider and Screens.register must be made accessible
@TheGlitch76
Copy link
Member

I can handle the Screens AWs and the ContainerFactories. I've got patchwork-containers started locally but it needed to be rewritten since Nuclear was using MethodHandles from pre-AW.

@Devan-Kerman
Copy link

this is on fabric too :tiny_potato:

@TheGlitch76
Copy link
Member

This mod is interesting largely because it's required for Botania

:tiny_potato:

@kitlith
Copy link
Contributor

kitlith commented Jul 26, 2020

In addition, curios is available on fabric for 1.16, but patchwork is still on 1.14.

There are several mod APIs at this point that I think it'd be worth investigating forge mods interacting with the fabric version of the api, but the ones I've seen so far are not present on 1.14, which makes testing that and developing a framework around that a bit more difficult.

In the meantime, there are always more forge events and stuff to implement.

@florensie
Copy link
Member

Curios API uses IMC on Forge so using the Fabric counterpart wouldn't work here.

@TheGlitch76
Copy link
Member

Hypothetically someone would make a wrapper lib that translates the IMC API to the underlying fabric one, but that's out of scope for here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features needed for mod A list of things needed for a specific Forge mod to work
Projects
None yet
Development

No branches or pull requests

6 participants