Skip to content

Commit

Permalink
Fixes merge issues caused by merging new changes into the trigger rew…
Browse files Browse the repository at this point in the history
…ork code. (#6447)

* Fix version number mishap

* move timeless jewel stuff (#5747)

* move timeless jewel stuff

* add back all the local versions of functions for future use

* Help section improvements (#6156)

* increase size of box and text

* implement hotkey to directly open help at a given section

* add ability to "fast scroll" to next section

* add section heights to changelog

* update txt

* fix merge issue

* fix line overlap and add note about scrollbars

* Add lot of stuff for ancestor league (#6288)

* FEAT: impl explode and extra support mods

* FEAT: impl new aura recovery mod

* FEAT: impl between you and linked target mods

* FEAT: impl Sentinel of Radiance mod

Currently implemented as less damage taken as that's what the
spreadsheet said.

I think this may be possible to implement like frost shield or other
"taken before you" mods given more info on stats of the sentinel.

* FEAT: impl reserved mana as armor mod

* FIX: use arbitrary taken before you instead of generic less dmg taken

* FIX: cache result of dmg type max hit str concat

* FEAT: code for generally supporting have no mods

* FEAT: impl resistance conversion mods

* FEAT: impl extra jewel func code for new chief mod

* FEAT: impl mod on all other slots condition

* FEAT: add new uniques

* Wording fixes, new unique

* Remove debugging lines

* Adding fire mastery explosion mod

* FIX: use ailment immunity flags from #6297

* Late breaking Chieftain change

* Update mod ranges

* Fix Amulet and belt

---------

Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>

* FEAT: add immunity flags to breakdown (#6389)

* FIX: fix totem duration mods not applying (#6388)

* Fix DPS on Vaal Flicker when using 2x 1h weapons (#6380)

The block was inside the 2 pass loop so was running twice
Also fixes the issue when you used a custom `more DPS` mod

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Apply RepeatCount according to their SkillTypes (#6376)

* Apply RepeatCount according to their SkillTypes

* Fix Vaal Flicker Strike

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Fix Immunities breakdown

* Fix Maata'a Teaching typo

* Fix allocation issue on convert while maintaining node id/name filtering (#6364)

* Fix lower channel time stat using red text (#6381)

* Fix lower channel time stat using red text

* Fix Channel time showing on calcs page for more skills than necessary

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Fix "Enemies maimed by you take inc damage over time` not in breakdown (#6400)

The mod was not displaying in the breakdown as it was using the dot flag instead of `DamageTakenOverTime`

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Fix Pierce and Chain count config not appearing sometimes (#6401)

* Fix Pierced count config not appearing sometimes

* Fix Chain config not appearing

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Regen ModCache

* Fix Snipe damage going negative (#6399)

* FIX: snipe damage going negative

* Set SnipeStacks min value earlier

---------

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>

* Null-check node.finalModList when hovering trees (#6408)

Looks like node.finalModList is not initalized when hovering trees, this
simply null checks it.

Closes #6405

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>

* Update 3.22 tree (#6411)

* update tree

* Fix rewording on Chieftain Node

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Fix Snipe showing DPS values when triggering support skills (#6415)

Added damage was still contributing to the damage of the skill so it was showing DPS numbers even if the skill was actually dealing no damage
Also removes the debug tooltip I forgot to remove from testing

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* 3.22 Additions (#6418)

* FEAT: impl more sources of self hit dmg

This code has been moved from #4599 after abandoning cwdt loop support.

* FIX: spelling

* FIX: remove file implemented in #4599

* Add support for non-Boneshatter Trauma

* Add new gems from 3.22 and other stuff

* Fix Crucible Export

* Fix Ruthless support to work with all ailments

* Update for actual support gem

* Support inc stun duration per trauma

* add devour, volatility and locus mine support (#6412)

* add devour, volatility and locus mine support

* Add full support for gems

Add mine tag to Locus Mine
Add support for Anomalous Devour
Fix Mine PvP damage multiplier
Fix flags for damage against full/low life enemies

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Spellblade support (#6343)

* Initial spellblade support

* Update label for spellblade damage breakdown

* Update with actual stats and qualities

* Update .txt too

* Floor all final flat values

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Fix export

* Add spacing and fix typos

Alter the breakdowns to no longer show the damage taken multi/taken % line if the value has not changed
Added spacing to the lines so you can more clearly read the breakdown when you have multiple taken as elements
Fix some spacing and spelling mistakes

---------

Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com>
Co-authored-by: Lilylicious <lily.hammerskog@gmail.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Regisle <49933620+Regisle@users.noreply.github.com>
Co-authored-by: Lily <Lilylicious@users.noreply.github.com>

* Regen ModCache

* FIX: allow setting inspiration charges to 0 (#6421)

* Add support for Guardian's Blessing no reservation for auras (#6425)

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>

* FEAT: impl sadism less ailment duration mod (#6431)

* FIX: incorrect increased usage mod range (#6434)

* Implement Corrupting Cry support (#6436)

* FEAT: impl Corrupting Cry support

* FIX: crash caused by incorrect capitalization

* FIX: add statMap and baseFlags to txt template

* FIX: spelling

* Revert "FEAT: impl Corrupting Cry support"

* FIX: reimplement using generic physDot

* FIX: copy paste issue

* FIX: cap corrupting blood staged.

Note that this config option also is affected by the one off bug in
config tab code.

* FIX: off by one in the config

* FIX: don't override skillData.durationSecondary

Overriding skillData.durationSecondary of exterted attacks may mess with
secondary effect of skills such as Dominating Blow

* FIX: CorruptingCry cfg stages not affecting exerts

* FIX: crash when hovering over more mult

* change dot type to corrupting blood to prevent dot from stacking

* Remove Attack dot addition + move config

* Fix removal of line

* Empty

---------

Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Add support for new Ancestor uniques (#6426)

* Add mod text only

Signed-off-by: Wires77 <Wires77@users.noreply.github.com>

* Fix Level requirements and add Replica Dragonfang's Flight

* Support Ahuana's Bite

* Support Bound Fate

* Support Kahuturoa's Certainty

* Support Rakiata's Dance

* Fix global gem level/quality name change

---------

Signed-off-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Removing allocated mastery from hover list (#6374)

* Removing allocated mastery from hover list

* Updating wording on mastery

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Add Ruthless tree (#6367)

* Add support for Ruthless trees

* Fix export URL for Ruthless trees

* Removed data.json

* Fix PR comments

* Fix edge cases around converting and importing

* Updating support for 3rd party ruthless tree links

* Update tree and add Tattoos

* Add support for new Ruthless tree mods

* Fix comment

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Support ruthless for poeskilltree

* Optimize itemLib.applyRange, improve startup time (#6407)

* Add applyRange tests

* Optimize itemLib.applyRange, improve startup time

* Fix tree import crash

* Tattoo implementation (#6396)

* Initial tattoo implementation

* Tattoo spec update

* Tattoo export

* Update spec

* Fix spec

* New dat files

* More fixes

* Add artwork, restrict Makanga tattoos

Signed-off-by: Wires77 <Wires77@users.noreply.github.com>

* Fix bug with saving/loading, cleanup code

* Fixed import bug and matched format for save files

* Fixing logic issues preventing proper tattoos from appearing

* Fixed bug with linked node count and supported new tattoo jewel

* Temp fix for effectSprites

* Can't tattoo changed nodes

* Fix tattoo interaction with Timeless jewels

* Update tree, fix more bugs

* Add dropdown search

* Add help text to tattoo dropdown

* Fix stat description error

* Dynamically set popup width

* Made popup width fully dynamic

* Truncate mod lines in tattoo popup

* text wrap in popup

* Dynamic word wrapping, ignoring GGG wrapping

* Revert tree merge

---------

Signed-off-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com>

* Fix secondary effect skills being added as supports (#6393)

* FIX:secondary effect skills being added as support

* FIX: cleanup duplicate code

* Fix Bleed/Ignite Stack potential issues (#6386)

The config was not affecting the number of bleeds/ignites affecting the enemy and was instead only affecting the average roll %
Ignite and Bleed roll % was not calculated to be at least 50% roll as a minimum
Ignite was also not taking into account Hit Chance when calculating the average roll
Breakdowns were improved to show the potential when max stacks is more than 1

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Regen ModCache

* Version dropdown QoL (#6365)

* Version dropdown QoL

* ruthless update

* Add support for Fresh Meat Support (#6443)

* Add support for Fresh Meat Support

* Adding general support for increased minion critical strike chance

* Move Config

---------

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>

* Implement Sacrifice, Frigid Bond, Guardian's Blessing, Controlled Blaze

* Add initial support for Guardian Minions (#6445)

Adds support for the new Guardian minions to show in the sidebar. The level is manually set to 85 right now as we don't support the `minion_actor_level_is_user_level_up_to_maximum` stat yet

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

* Release 2.32.0 (#6440)

* Prepare release 2.32.0

* Fix changelogs

* Spelling

---------

Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>

---------

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Signed-off-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
Co-authored-by: Regisle <49933620+Regisle@users.noreply.github.com>
Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Co-authored-by: Peechey <92683202+Peechey@users.noreply.github.com>
Co-authored-by: Tomas Slusny <slusnucky@gmail.com>
Co-authored-by: Lilylicious <lily.hammerskog@gmail.com>
Co-authored-by: Lily <Lilylicious@users.noreply.github.com>
Co-authored-by: Lancej <1243476+Lancej@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
  • Loading branch information
12 people authored Aug 24, 2023
1 parent d17fb9e commit 2581e60
Show file tree
Hide file tree
Showing 103 changed files with 199,234 additions and 50,399 deletions.
52 changes: 52 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,57 @@
# Changelog

## [v2.32.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.32.0) (2023/08/24)

[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.31.2...v2.32.0)

<!-- Release notes generated using configuration in .github/release.yml at dev -->

## What's Changed
### New to Path of Building
- Add support for tattoos [\#6396](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6396) ([Wires77](https://github.com/Wires77))
- Add support for Ruthless tree [\#6367](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6367) ([Wires77](https://github.com/Wires77))
* Add support for 3.22 skill gems by [\#6418](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6418), [\#6431](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6431), [\#6436](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6436), [\#6443](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6443), [\#6425](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6425), ([LocalIdentity](https://github.com/LocalIdentity), [Lilylicious](https://github.com/Lilylicious), [Regisle](https://github.com/Regisle), [Paliak](https://github.com/Paliak), [Wires77](https://github.com/Wires77), [deathbeam](https://github.com/deathbeam))
* Full Support
* Locus Mine
* Devour
* Volatility
* Sadism
* Spellblade
* Trauma
* Corrupting Cry
* Frigid Bond
* Guardian's Blessing
* Fresh Meat
* Sacrifice
* Controlled Blaze
- Add support for new Chieftain and Guardian ascendancy nodes [\#6288](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6288) ([Paliak](https://github.com/Paliak))
- Add initial support for Guardian minion nodes [\#6445](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6445) ([LocalIdentity](https://github.com/LocalIdentity))
- Add self-hit calculations for Scolds Bridle, Eye of Innocence and Heartbound Loop [\#6250](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6250) ([Paliak](https://github.com/Paliak))
- Add support for new Ancestor uniques [\#6426](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6426) ([LocalIdentity](https://github.com/LocalIdentity), [Wires77](https://github.com/Wires77))
- Improve startup time [\#6407](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6407) ([Lancej](https://github.com/Lancej))
### User Interface
- Help section improvements [\#6156](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6156) ([Regisle](https://github.com/Regisle))
- Add immunity flags to defence avoidance breakdown [\#6389](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6389) ([Paliak](https://github.com/Paliak))
- Removing allocated mastery from hover list [\#6374](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6374) ([Wires77](https://github.com/Wires77))
- Improve sync of tree version and version dropdown [\#6365](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6365) ([Peechey](https://github.com/Peechey))
### Fixed Bugs
- Fix nodes not being able to be allocated after converting a tree [\#6364](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6364) ([Peechey](https://github.com/Peechey))
- Fix totem duration mods not applying [\#6388](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6388) ([Paliak](https://github.com/Paliak))
- Fix DPS on Vaal Flicker when using 2x 1h weapons [\#6380](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6380) ([LocalIdentity](https://github.com/LocalIdentity))
- Fix Repeat count for minion skills [\#6376](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6376) ([Wires77](https://github.com/Wires77))
- Fix Snipe damage going negative [\#6399](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6399) ([Paliak](https://github.com/Paliak))
- Fix Snipe showing DPS values when triggering support skills [\#6415](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6415) ([LocalIdentity](https://github.com/LocalIdentity))
- Fix Doom Blast not working with Forbidden Shako [\#6393](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6393) ([Paliak](https://github.com/Paliak))
- Fix Bleed/Ignite Stack potential issues [\#6386](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6386) ([LocalIdentity](https://github.com/LocalIdentity))
### Accuracy Improvements
- Update 3.22 skill tree [\#6411](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6411) ([Regisle](https://github.com/Regisle))
- Allow setting inspiration charges to 0 [\#6421](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6421) ([Paliak](https://github.com/Paliak))
- Fix "Enemies maimed by you take inc damage over time" not in breakdown display [\#6400](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6400) ([LocalIdentity](https://github.com/LocalIdentity))
- Fix Pierce and Chain count config not appearing sometimes [\#6401](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6401) ([LocalIdentity](https://github.com/LocalIdentity))
- Fix lower channel time stat using red text [\#6381](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6381) ([LocalIdentity](https://github.com/LocalIdentity))
- Fix incorrect increased usage mod range on Cinderswallow Urn [\#6434](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6434) ([Paliak](https://github.com/Paliak))


## [v2.31.2](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.31.2) (2023/08/16)

[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.31.1...v2.31.2)
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Feature requests are always welcome. Note that not all requests will receive an
### Before submitting a pull request:
* Familiarise yourself with the code base [here](docs/rundown.md) to get you started.
* There is a [Discord](https://discordapp.com/) server for **active development** on the fork and members are happy to answer your questions there.
If you are interested in joining, send a private message to any of **Cinnabarit#1341**, **LocalIdentity#9871**, **Yamin#5575** and we'll send you an invitation.
If you are interested in joining, send a private message to **localidentity** or **wires77** and we'll send you an invitation.

### When submitting a pull request:
* **Pull requests must be created against the `dev` branch**, as all changes to the code are staged there before merging to `master`.
Expand Down
97 changes: 78 additions & 19 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,86 @@
BETA VERSION[2.32.0][2023/08/24]

--- User Interface ---
* Display Cast When damage taken threshold in the trigger rate section

--- Fixed Bugs ---
* Fix Tawhoa's Chosen granting mod being incorrectly parsed
* Fix Tawhoa's Chosen not working with strike skills


VERSION[2.32.0][2023/08/24]

--- New to Path of Building ---
* Add support for tattoos (Wires77)
* Add support for Ruthless tree (Wires77)
* Add support for 3.22 skill gems by (LocalIdentity, Lilylicious, Regisle, Paliak, Wires77, deathbeam)
* Full Support
* Locus Mine
* Devour
* Volatility
* Sadism
* Spellblade
* Trauma
* Corrupting Cry
* Frigid Bond
* Guardian's Blessing
* Fresh Meat
* Sacrifice
* Controlled Blaze
* Add support for new Chieftain and Guardian ascendancy nodes (Paliak)
* Add initial support for Guardian minion nodes (LocalIdentity)
* Add self-hit calculations for Scolds Bridle, Eye of Innocence and Heartbound Loop (Paliak)
* Add support for new Ancestor uniques by (Wires77, LocalIdentity)
* Improve startup time (Lancej)

--- User Interface ---
* Help section improvements (Regisle)
* Add immunity flags to defence avoidance breakdown (Paliak)
* Removing allocated mastery from hover list (Wires77)
* Improve sync of tree version and version dropdown (Peechey)

--- Fixed Bugs ---
* Fix nodes not being able to be allocated after converting a tree (Peechey)
* Fix totem duration mods not applying (Paliak)
* Fix DPS on Vaal Flicker when using 2x 1h weapons (LocalIdentity)
* Fix Repeat count for minion skills (Wires77)
* Fix Snipe damage going negative (Paliak)
* Fix Snipe showing DPS values when triggering support skills (LocalIdentity)
* Fix Doom Blast not working with Forbidden Shako (Paliak)
* Fix Bleed/Ignite Stack potential issues (LocalIdentity)

--- Accuracy Improvements ---
* Update 3.22 skill tree (Regisle)
* Allow setting inspiration charges to 0 (Paliak)
* Fix "Enemies maimed by you take inc damage over time" not in breakdown display (LocalIdentity)
* Fix Pierce and Chain count config not appearing sometimes (LocalIdentity)
* Fix lower channel time stat using red text (LocalIdentity)
* Fix incorrect increased usage mod range on Cinderswallow Urn (Paliak)

VERSION[2.31.2][2023/08/16]

--- Fixed Bugs ---
* Fix issue when importing characters (Wires77)
* Fix typo with Ignite Stack Potential Override (Wires77)

BETA VERSION[2.31.1][2023/08/16]

--- Fixed Crashes ---
* Fix Crash when using a weapon with a crafted Trigger mod

VERSION[2.31.1][2023/08/16]

--- User Interface ---
* Lower contrast of gem select highlight (ryuukk)

--- Accuracy Improvements ---
* Undo incorrect Explosive Arrow change (Lilylicious)
* Fix Frozen Legion benefiting from exerts (Lilylicious)
* Fix Combustion debuff not applying when a non-damaging skill precedes a damaging skill (Lilylicious)
* Fix Blood Sacrament not being capped by Cooldown (LocalIdentity)
* Fix Tree conversion stopping you from allocating some tree nodes (LocalIdentity)
* Fix Mana cost when using 'Wait for max unleash seals' (busterw)

BETA VERSION[2.31.0][2023/08/15]
--- Implemented Enhancements ---
* Support for triggered skills has been reworked.
Expand All @@ -28,25 +106,6 @@ BETA VERSION[2.31.0][2023/08/15]
* Fixed many self triggers counting as self cast.
* Fixed incorrect handling of gems supported by more than one trigger.

VERSION[2.31.2][2023/08/16]

--- Fixed Bugs ---
* Fix issue when importing characters (Wires77)
* Fix typo with Ignite Stack Potential Override (Wires77)

VERSION[2.31.1][2023/08/16]

--- User Interface ---
* Lower contrast of gem select highlight (ryuukk)

--- Accuracy Improvements ---
* Undo incorrect Explosive Arrow change (Lilylicious)
* Fix Frozen Legion benefiting from exerts (Lilylicious)
* Fix Combustion debuff not applying when a non-damaging skill precedes a damaging skill (Lilylicious)
* Fix Blood Sacrament not being capped by Cooldown (LocalIdentity)
* Fix Tree conversion stopping you from allocating some tree nodes (LocalIdentity)
* Fix Mana cost when using 'Wait for max unleash seals' (busterw)

VERSION[2.31.0][2023/08/15]

--- New to Path of Building ---
Expand Down
34 changes: 14 additions & 20 deletions help.txt
Original file line number Diff line number Diff line change
@@ -1,21 +1,13 @@
---[Help File][1]
---[Help File Introduction]

This file contains a list of shortcuts, and other misc things PoB has
This file contains a list of shortcuts, and other misc information about PoB functionality
While holding shift scroll bars in help section and version history will jump to the previous/next section while scrolling

---[Contents][2]
---[Contents]

1. Intro
2. Contents
3. FAQ
4. Hotkeys
5. Other Notable Things
6. Timeless Jewels
7. Party Tab
8. Items Tab
---[FAQ]

---[FAQ][3]

---[Hotkeys][4]
---[Hotkeys]

General Shortcuts:

Expand All @@ -35,13 +27,14 @@ Ctrl + N New build (in build selection menu)
Ctrl + S Save build to file
Ctrl + U Check for update
Ctrl + V or RMB Paste
Ctrl + W or Mouse 4 Close Build (gives save prompt if unsaved)
Ctrl + W or
Mouse 4 Close Build (gives save prompt if unsaved)
Ctrl + X Cut
Ctrl + Y Redo
Ctrl + Z Undo
Ctrl + BSP / DEL Faster text delete
Ctrl + + /-/0 Zoom in / Out / Reset
F1 Open item/gem/etc in poewiki.net
F1 Open item/gem/etc in poewiki.net, or if nothing to open, opens help file
F2 Rename item, set, etc.
E On an equipped item will open it on the edit menu on the right.
Ctrl + LMB Enable / disable gems
Expand All @@ -50,6 +43,7 @@ Mouse 4/5 Undo / Redo path respectively (in build selection menu)
Shift While scrolling on a slider makes it 5* times faster
Ctrl While scrolling on a slider makes it 5* times slower
* default of 5, some scroll bars have more or less extreme modifiers to scroll speed
and scroll bars in help section and version history will jump to the previous/next section

When creating an item either through item creator or adding an item pressing ctrl will add it to the first slot
and ctrl+shift will add it to the second slot e.g. offhand for a weapon.
Expand Down Expand Up @@ -80,11 +74,11 @@ DEV[F5 Restart]
DEV[F6 Run garbage collector]
DEV[Shift Copy export xml to clipboard (hold key during export)]

---[Other Notable Things][5]
---[Other Notable Things]

Adding ^ and then a number or hex code before text will change the colour of the text, eg ^^77 will make the following text white until the next colour marker is set.

---[Timeless Jewels][6]
---[Timeless Jewels]

Timeless jewels modify nodes in a radius based off their seed, the same seed will apply the same changes to the same small/notable nodes so that is the number you look for. The Conqueror (name on the jewel) only affects the keystone.

Expand Down Expand Up @@ -118,7 +112,7 @@ Militant Faith jewels also have the option to select the other mods on the jewel
Advanced tricks:
For Militant Faith, if you don't want any nodes to change, you can just sort by devotion. As unchanged nodes add devotion, the ones with the most devotion will be the ones with unchanged nodes

---[Party Tab][7]
---[Party Tab]

The Party tab Allows you to import support characters and have their auras and curses apply

Expand All @@ -135,7 +129,7 @@ Your curses will take priority over a support's
For now Enemy conditions and Modifiers are not exported but can be imported if its saved in the XML, and Links skills are not exported or parsed
Some auras like Mines which use a stack value for their effect will not apply as their stack value is missing

---[Items Tab][8]
---[Items Tab]

The Item Tab in Path of Building allows you to plan out the gear you will use for your character. To access the Item Tab, click on the "Items" tab located at the top of the screen.

Expand Down
48 changes: 48 additions & 0 deletions spec/System/TestItemTools_spec.lua
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
local applyRangeTests = {
-- Number without range
[{ "+10 to maximum Life", 1.0, 1.0 }] = "+10 to maximum Life",
[{ "+10 to maximum Life", 1.0, 1.5 }] = "+15 to maximum Life",
[{ "+10 to maximum Life", 0.5, 1.0 }] = "+10 to maximum Life",
[{ "+10 to maximum Life", 0.5, 1.5 }] = "+15 to maximum Life",
-- One range
[{ "+(10-20) to maximum Life", 1.0, 1.0 }] = "+20 to maximum Life",
[{ "+(10-20) to maximum Life", 1.0, 1.5 }] = "+30 to maximum Life",
[{ "+(10-20) to maximum Life", 0.5, 1.0 }] = "+15 to maximum Life",
[{ "+(10-20) to maximum Life", 0.5, 1.5 }] = "+22 to maximum Life",
-- Two ranges
[{ "Adds (60-80) to (270-300) Physical Damage", 1.0, 1.0 }] = "Adds 80 to 300 Physical Damage",
[{ "Adds (60-80) to (270-300) Physical Damage", 1.0, 1.5 }] = "Adds 120 to 450 Physical Damage",
[{ "Adds (60-80) to (270-300) Physical Damage", 0.5, 1.0 }] = "Adds 70 to 285 Physical Damage",
[{ "Adds (60-80) to (270-300) Physical Damage", 0.5, 1.5 }] = "Adds 105 to 427 Physical Damage",
-- Range with increased/reduced
[{ "(10--10)% increased Charges per use", 1.0, 1.0 }] = "10% reduced Charges per use",
[{ "(10--10)% increased Charges per use", 1.0, 1.5 }] = "15% reduced Charges per use",
[{ "(10--10)% increased Charges per use", 0.5, 1.0 }] = "0% increased Charges per use",
[{ "(10--10)% increased Charges per use", 0.5, 1.5 }] = "0% increased Charges per use",
[{ "(10--10)% increased Charges per use", 0.0, 1.0 }] = "10% increased Charges per use",
[{ "(10--10)% increased Charges per use", 0.0, 1.5 }] = "15% increased Charges per use",
-- Range with constant numbers after
[{ "(15-20)% increased Cold Damage per 1% Cold Resistance above 75%", 1.0, 1.0 }] = "20% increased Cold Damage per 1% Cold Resistance above 75%",
[{ "(15-20)% increased Cold Damage per 1% Cold Resistance above 75%", 1.0, 1.5 }] = "30% increased Cold Damage per 1% Cold Resistance above 75%",
[{ "(15-20)% increased Cold Damage per 1% Cold Resistance above 75%", 0.5, 1.0 }] = "18% increased Cold Damage per 1% Cold Resistance above 75%",
[{ "(15-20)% increased Cold Damage per 1% Cold Resistance above 75%", 0.5, 1.5 }] = "27% increased Cold Damage per 1% Cold Resistance above 75%",
-- High precision range
[{ "Regenerate (66.7-75) Life per second", 1.0, 1.0 }] = "Regenerate 75 Life per second",
[{ "Regenerate (66.7-75) Life per second", 1.0, 1.5 }] = "Regenerate 112.5 Life per second",
[{ "Regenerate (66.7-75) Life per second", 0.5, 1.0 }] = "Regenerate 70.9 Life per second",
[{ "Regenerate (66.7-75) Life per second", 0.5, 1.5 }] = "Regenerate 106.3 Life per second",
-- Range with plus sign that is removed when negative
[{ "+(-25-50)% to Fire Resistance", 1.0, 1.0 }] = "+50% to Fire Resistance",
[{ "+(-25-50)% to Fire Resistance", 1.0, 1.5 }] = "+75% to Fire Resistance",
[{ "+(-25-50)% to Fire Resistance", 0.0, 1.0 }] = "-25% to Fire Resistance",
[{ "+(-25-50)% to Fire Resistance", 0.0, 1.5 }] = "-37% to Fire Resistance",
}

describe("TestItemTools", function()
for args, expected in pairs(applyRangeTests) do
it(string.format("tests applyRange('%s', %.2f, %.2f)", unpack(args)), function()
local result = itemLib.applyRange(unpack(args))
assert.are.equals(expected, result)
end)
end
end)
14 changes: 13 additions & 1 deletion src/Classes/ImportTab.lua
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,18 @@ function ImportTabClass:ImportPassiveTreeAndJewels(json, charData)
end
end

if charPassiveData.skill_overrides then
for nodeId, override in pairs(charPassiveData.skill_overrides) do
override.id = nodeId
local modCount = 0
for _, statLine in ipairs(override.stats) do
self.build.spec:NodeAdditionOrReplacementFromString(override, statLine, modCount == 0)
modCount = modCount + 1
end
override.dn = override.name
end
end

if errMsg then
self.charImportStatus = colorCodes.NEGATIVE.."Error processing character data, try again later."
return
Expand Down Expand Up @@ -602,7 +614,7 @@ function ImportTabClass:ImportPassiveTreeAndJewels(json, charData)
end
end
end
self.build.spec:ImportFromNodeList(charData.classId, charData.ascendancyClass, charPassiveData.hashes, charPassiveData.mastery_effects or {}, latestTreeVersion)
self.build.spec:ImportFromNodeList(charData.classId, charData.ascendancyClass, charPassiveData.hashes, charPassiveData.skill_overrides, charPassiveData.mastery_effects or {}, latestTreeVersion .. (charData.league:match("Ruthless") and "_ruthless" or ""))
self.build.spec:AddUndoState()
self.build.characterLevel = charData.level
self.build.characterLevelAutoMode = false
Expand Down
Loading

0 comments on commit 2581e60

Please sign in to comment.