Party tab improvements #6143
Merged
Party tab improvements #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regisle
force-pushed
the
PartyTabImprovements
branch
from
bc42a14
to
399b959
Compare
Regisle
force-pushed
the
PartyTabImprovements
branch
from
12af6ee
to
e21a1b3
Compare
LocalIdentity
approved these changes
Sep 9, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* reenable export of enemy conditions/modifiers * improvements to UI relating to enemy mods * add UI guides to make working with all the controls easier * sort aura and curse simple list * improve mod parsing * add some checking for party conditions * fix exporting it exporting values that come from party * fix simple enemy mods * fix vaal auras * add support for exporting generic buffs like harbinger of time * allow for more generic other effects * improve extra aura grabbing * move ally buffs into a fake actor * allow for multiple enemy mods of the same stat (eg eye of malice expose) * improve enemy mods export * add support for some player mods before links need them * update help txt * fix spelling * improve error message * rename UIGuides to theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds various improvements to the party tab
Ideally there are 18 remaining issues I would like to fix, this PR should address 9 of the most important ones, and another PR (reliant on link skills) will address 1 more
remaining issues to be fixed in a future PR
4) improve tagging of enemy conditions/mods (eg exposure)
6) fix some aura tags like stack var
7) link skills (requires #5959 and #6139, will likely be in a separate PR)
13) undo states could be improved
14) importing of other builds in build folder (without having to export/import them again)
15) tagging which "support" a given aura/curse etc are from, which would also remove the need for append/replace (as it would always replace if its from the same "support" and append if its not)
16) tagging auras and curses as belonging to the party
17) rendering of item states from party (this seems like it just bloats the save file so hasnt been done yet)
18) maybe sort/cull advanced versions (with opt out)