Add proper support for DPS with Scourge Arrow, Divine Ire, Flameblast and Incinerate #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channeling skills that used stages did not have their hit rate modified by the time it took to channel those stages This PR adds `hitTimeMultiplier` values for Scourge Arrow, Divine Ire, Flameblast and Incinerate Snipe is handled in it's own PR This shows the channel time in the sidebar along with the correct hit rate for these skills Adds boxes to the config page to set the number of nearby enemies for Divine Ire to calculate the correct charge rate
This was referenced May 31, 2023
Paliak
reviewed
Jun 13, 2023
src/Modules/CalcOffence.lua
Outdated
Comment on lines
2058
to
2077
| if skillData.hitTimeOverride and not skillData.triggeredOnDeath then | ||
| breakdown.HitSpeed = { } | ||
| t_insert(breakdown.HitSpeed, s_format("1 / %.2f ^8(hit time override)", output.HitTime)) | ||
| t_insert(breakdown.HitSpeed, s_format("= %.2f", output.HitSpeed)) | ||
| elseif skillData.hitTimeMultiplier and output.Time and not skillData.triggeredOnDeath then | ||
| breakdown.HitTime = { } | ||
| if m_floor(skillData.hitTimeMultiplier) ~= skillData.hitTimeMultiplier then | ||
| t_insert(breakdown.HitTime, s_format(colorCodes.CUSTOM.."NOTE: First stage has a %.2fx channel time multiplier", skillData.hitTimeMultiplier - m_floor(skillData.hitTimeMultiplier))) | ||
| end | ||
| t_insert(breakdown.HitTime, s_format("%.2f ^8(cast time)", output.Time)) | ||
| t_insert(breakdown.HitTime, s_format("x %.2f ^8(channel time multiplier)", skillData.hitTimeMultiplier)) | ||
| t_insert(breakdown.HitTime, s_format("= %.2f", output.HitTime)) | ||
| breakdown.HitSpeed = { } | ||
| if output.Cooldown then | ||
| t_insert(breakdown.HitSpeed, s_format("1 / (%.2f + %.2f) ^8(hit time + cooldown)", output.HitTime, output.Cooldown)) | ||
| else | ||
| t_insert(breakdown.HitSpeed, s_format("1 / %.2f ^8(hit time)", output.HitTime)) | ||
| end | ||
| t_insert(breakdown.HitSpeed, s_format("= %.2f", output.HitSpeed)) | ||
| end |
There was a problem hiding this comment.
Thoughts on moving this part into a lambda instead of copying it below?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channelling skills that used stages did not have their hit rate modified by the time it took to channel those stages
This PR adds
hitTimeMultipliervalues for Scourge Arrow, Divine Ire, Flameblast and IncinerateSnipe is handled in it's own PR
This shows the channel time in the sidebar along with the correct hit rate for these skills
This also fixes the skills not working correctly when added to Full DPS such as Divine Ire Totems
Fixes #3771
Adds boxes to the config page to set the number of nearby enemies for Divine Ire to calculate the correct charge rate
