Fix multiple instances of 'x stat is increased by overcapped y resistance' stacking #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Aug 13, 2023
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3826
Description of the problem being solved:
Modifiers that increase a stat by another stat do not stack. This includes not just overcapped/uncapped resistance modifiers (formless flame), but also modifiers like crit chance is increased by spell suppression chance. These are all binary modifiers, they're either active or not, having two isn't any different from having one.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/nYecxuBBG_K2