Implement flamethrower trap DPS #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilylicious
force-pushed
the
flamethrowerTrapDPS
branch
from
772fa18
to
6bdfbf4
Compare
Lilylicious
force-pushed
the
flamethrowerTrapDPS
branch
from
6bdfbf4
to
115694f
Compare
LocalIdentity
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Flamethrower trap had hidden stats such as hit rate which made it impossible to accurately implement DPS for it. I asked GGG directly and got answers on how it works, so here's an implementation.
I added two skill parts, one for a single trap and one that takes into account average active traps to take into account using it as a main skill, due to its cooldown.
Link to a build that showcases this PR:
https://pobb.in/41YgDbTmv4EF
Before screenshot:
After screenshot: