Fix Ability to delete non-empty folder.

[n1tr0xs]

Fixes #1823 .

Description of the problem being solved:

Added the ability to delete a folder, and all builds stored within the folder.

Steps taken to verify a working solution:

• Create folder
• Create build in folder
• Delete folder

Before screenshot:

After screenshot:

[Paliak]

Not sure i'm a fan of using os.execute. Especially with user input.

If you want to implement this i'd say recursively delete files and directories with RemoveDir, NewFileSearch and os.remove Something like (not tested):

function deleteDirectory(dir)
    local function removeContents(path)
        local search = NewFileSearch(path .. "/*")
        while search:NextFile() do
            local item = path .. "/" .. search:GetFileName()
            if search:IsDirectory() then
                if search:GetFileName() ~= "." and search:GetFileName() ~= ".." then
                    removeContents(item)
                    RemoveDir(item)
                end
            else
                os.remove(item)
            end
        end
    end

    removeContents(dir)
    RemoveDir(dir)
end

[zao]

I'm also not super keen on leveraging os.system as the command lines are both unportable and how it's non-trivial to robustly escape arguments in the command line for arbitrary filenames.
The iteration solution is better, but could lead to surprises as entries are removed as we sweep.

A possible alternative if we really want such a powerful primitive is that we could expose std::filesystem::remove_all in SimpleGraphic, either as an option to RemoveDir or as a separate function.

[n1tr0xs]

Could you check it out in your free time ?

[n1tr0xs]

And i have an idea, but i'm not sure about this practice in LUA.
To avoid repetative lines we can use this code:

function deleteDirectory(dir)
    local funcs = {}
    funcs[false] = os.remove -- delete file
    funcs[true] = deleteDirectory -- delete directory

    for k, v in pairs(funcs) do
        local search = NewFileSearch(dir..'/*', k)
        if search then
            funcs[k](dir..'/'..search:GetFileName())
            while search:NextFile() do
                funcs[k](dir..'/'..search:GetFileName())
            end
        end
    end

    RemoveDir(dir)
end

What do you think about this ?

[Paliak]

I think adding support for recursive folder deletion from the SG side would be the best way to tackle this feature.

The method you implemented suffers from the issue that zao mentioned. You're changing the environment from underneath an iterator which is generally not a good idea.

https://en.cppreference.com/w/cpp/filesystem/directory_iterator

If a file or a directory is deleted or added to the directory tree after the directory iterator has been created, it is unspecified whether the change would be observed through the iterator.

Imo if you want to stick to the lua side you'd need to first make a list of all the elements to be deleted and then delete them in the right order. You'd probably be looking at a DFS kinda approach.

[n1tr0xs]

Yeah... It seems that things are much more complicated on the LUA side.